Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in tab stop instructions #6905

Merged

Conversation

codeofdusk
Copy link
Contributor

@codeofdusk codeofdusk commented Aug 19, 2023

Details

This PR fixes a small typo in the tab stop instructions.

Context

Discovered during 2.39.0 release validation.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA

@codeofdusk codeofdusk requested a review from a team as a code owner August 19, 2023 02:38
@codeofdusk codeofdusk force-pushed the improve-tab-stop-instructions-everywhere branch from 37f486a to c52d240 Compare August 19, 2023 02:59
Copy link
Contributor

@JGibson2019 JGibson2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the guidance-content.test snapshots haven't been updated and that's causing a failure; we'd need to update that in the e2e folder and then we should be good to go! Other than that LGTM

@madalynrose
Copy link
Contributor

On second thought, I actually think this is as designed. The ad-hoc test does not involve DetailsView and therefore there is no window that the user needs to return to after testing the page. They just need to traverse the page and notice if the visualization marks any unexpected behavior.

@codeofdusk codeofdusk changed the title fix: Improve tab stop instructions everywhere fix: Fix typo in tab stop instructions Aug 21, 2023
Signed-off-by: Bill Dengler <codeofdusk@gmail.com>
@codeofdusk codeofdusk force-pushed the improve-tab-stop-instructions-everywhere branch from 74528b2 to 016cc5c Compare August 21, 2023 18:19
@codeofdusk codeofdusk dismissed JGibson2019’s stale review August 23, 2023 20:29

Scope of PR reduced

@codeofdusk codeofdusk merged commit 73ce5fb into microsoft:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants