Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in tab stop instructions #6905

Merged
merged 5 commits into from
Aug 23, 2023
Merged

fix: Fix typo in tab stop instructions #6905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
760f8f1
Update tab stop instructions everywhere
codeofdusk Aug 19, 2023
c52d240
Update test snapshots via automation
codeofdusk Aug 19, 2023
6e46b38
Update guidance snapshots via automation
codeofdusk Aug 21, 2023
016cc5c
Back out changes to ad hoc tool
codeofdusk Aug 21, 2023
71d9ca7
in/on
codeofdusk Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DetailsView/components/adhoc-tab-stops-test-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ export const AdhocTabStopsTestView = NamedFC<AdhocTabStopsTestViewProps>(
<ol>
<li>
Use your keyboard to move input focus through all the interactive elements
in the page--
on the page&nbsp;&ndash;{' '}
<Markup.Emphasis>
please traverse the entire page before returning to this window
</Markup.Emphasis>
Expand Down
2 changes: 1 addition & 1 deletion src/content/adhoc/tabstops/how-to-test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export const createHowToTest = (headingLevel: number) => {
<li>Refresh the target page to put it in its default state.</li>
<li>Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.</li>
<li>
Use your keyboard to move input focus through all the interactive elements in the page:
Use your keyboard to move input focus through all the interactive elements on the page:
<ul>
<li>Use Tab and Shift+Tab to navigate between standalone controls.</li>
<li>Use the arrow keys to navigate between the focusable elements within a composite control.</li>
Expand Down
2 changes: 1 addition & 1 deletion src/tests/end-to-end/tests/content/__snapshots__/guidance-content.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ exports[`Guidance Content pages adhoc/tabstops/guidance matches the snapshot 1`]
Turn on the Show tab stops toggle. An empty circle will highlight the element with focus.
</li>
<li>
Use your keyboard to move input focus through all the interactive elements in the page:
Use your keyboard to move input focus through all the interactive elements on the page:
<ul>
<li>
Use Tab and Shift+Tab to navigate between standalone controls.
Expand Down
6 changes: 4 additions & 2 deletions ...s/unit/tests/DetailsView/components/__snapshots__/adhoc-tab-stops-test-view.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ exports[`AdhocTabStopsTestView render handles guidance 1`] = `
</p>
<ol>
<li>
Use your keyboard to move input focus through all the interactive elements in the page--
Use your keyboard to move input focus through all the interactive elements on the page –

<Emphasis>
please traverse the entire page before returning to this window
</Emphasis>
Expand Down Expand Up @@ -175,7 +176,8 @@ exports[`AdhocTabStopsTestView render handles no guidance 1`] = `
</p>
<ol>
<li>
Use your keyboard to move input focus through all the interactive elements in the page--
Use your keyboard to move input focus through all the interactive elements on the page –

<Emphasis>
please traverse the entire page before returning to this window
</Emphasis>
Expand Down