Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default deployment type from war to ftp #157

Merged
merged 2 commits into from
May 25, 2018
Merged

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented May 23, 2018

Since ftp is a more generic way for deployment, so making ftp to be the default deployment type could be a better choice.

Meanwhile this can fix the issue: #156

@jdneo jdneo added this to the webapp-1.2.0 milestone May 23, 2018
@jdneo jdneo requested a review from ansyral May 23, 2018 11:20
@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@222cacb). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #157   +/-   ##
==========================================
  Coverage           ?   60.53%           
==========================================
  Files              ?       50           
  Lines              ?     1566           
  Branches           ?      171           
==========================================
  Hits               ?      948           
  Misses             ?      558           
  Partials           ?       60
Impacted Files Coverage Δ
...crosoft/azure/maven/webapp/AbstractWebAppMojo.java 0% <ø> (ø)
...zure/maven/webapp/handlers/HandlerFactoryImpl.java 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 222cacb...e8cf251. Read the comment docs.

@jdneo jdneo merged commit 9a62157 into develop May 25, 2018
@jdneo jdneo deleted the cs/ftp-default branch May 25, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants