Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default deployment type from war to ftp #157

Merged
merged 2 commits into from
May 25, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure-webapp-maven-plugin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Property | Required | Description | Version
`<containerSettings>` | false | Specifies the docker container image to deploy to your Web App.<br>This setting is only applicable for Web App for Containers. Docker hubs and private container registries are both supported; see the [Container Setting](#container-setting) section of this README for details. | 0.1.0+
`<appSettings>` | false | Specifies the application settings for your Web App, which are defined in name-value pairs like following example:<br>`<property>`<br>&nbsp;&nbsp;&nbsp;&nbsp;`<name>xxxx</name>`<br>&nbsp;&nbsp;&nbsp;&nbsp;`<value>xxxx</value>`<br>`</property>` | 0.1.0+
`<stopAppDuringDeployment>` | false | Specifies whether stop target Web App during deployment. This will prevent deployment failure caused by IIS locking files. | 0.1.4+
`<deploymentType>` | false | Specifies the deployment approach you want to use, available options: <br><ul><li>war (by default): since 1.1.0</li><li>ftp: since 0.1.0</li></ul> | 0.1.0+
`<deploymentType>` | false | Specifies the deployment approach you want to use, available options: <br><ul><li>ftp (by default): since 0.1.0</li><li>war: since 1.1.0</li></ul> | 0.1.0+
`<resources>` | false | Specifies the artifacts to be deployed to your Web App when `<deploymentType>` is set to `ftp`.<br>See the [Deploy via FTP](#deploy-via-ftp) section for more details. | 0.1.0+
`<warFile>` | false | Specifies the location of the war file which is to be deployed when `<deploymentType>` is set to `war`.<br>If this configuration is not specified, plugin will find the war file according to the `finalName` in the project build directory. | 1.1.0+
`<path>` | false | Specify the context path for the deployment when `<deploymentType>` is set to `war`.<br>If this configuration is not specified, plugin will deploy to the context path: `/`, which is also known as the `ROOT`. | 1.1.0+
Expand Down
4 changes: 2 additions & 2 deletions azure-webapp-maven-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.microsoft.azure</groupId>
<artifactId>azure-webapp-maven-plugin</artifactId>
<version>1.1.0-SNAPSHOT</version>
<version>1.2.0-SNAPSHOT</version>
<packaging>maven-plugin</packaging>
<name>Maven Plugin for Azure Web Apps</name>
<description>Maven Plugin for Azure Web Apps</description>
Expand All @@ -22,7 +22,7 @@
<maven.plugin-testing.version>3.3.0</maven.plugin-testing.version>
<codehaus.plexus-utils.version>3.0.20</codehaus.plexus-utils.version>
<azure.ai.version>1.0.9</azure.ai.version>
<azure.maven-plugin-lib.version>1.0.0-SNAPSHOT</azure.maven-plugin-lib.version>
<azure.maven-plugin-lib.version>1.0.0</azure.maven-plugin-lib.version>
<junit.version>4.12</junit.version>
<mockito.version>2.4.0</mockito.version>
<spring-test.version>4.1.6.RELEASE</spring-test.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public abstract class AbstractWebAppMojo extends AbstractAzureMojo {
*
* @since 0.1.0
*/
@Parameter(property = "webapp.deploymentType", defaultValue = "war")
@Parameter(property = "webapp.deploymentType", defaultValue = "ftp")
protected String deploymentType;

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,11 @@ public ArtifactHandler getArtifactHandler(final AbstractWebAppMojo mojo) throws
throw new MojoExecutionException(DEPLOYMENT_TYPE_NOT_FOUND);
case UNKNOWN:
throw new MojoExecutionException(UNKNOWN_DEPLOYMENT_TYPE);
case FTP:
return new FTPArtifactHandlerImpl(mojo);
case WAR:
default:
return new WarArtifactHandlerImpl(mojo);
case FTP:
default:
return new FTPArtifactHandlerImpl(mojo);
}
}

Expand Down