Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support active directory pwd authentication #8565

Closed
wants to merge 1 commit into from

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Dec 4, 2019

Adds support for a new authentication model - username/password authentication with AAD.

@aaomidi
Copy link
Contributor Author

aaomidi commented Dec 4, 2019

Needs this to be merged before: microsoft/sqltoolsservice#899

@@ -79,6 +79,7 @@
"mssql.connectionOptions.authType.categoryValues.sqlLogin": "SQL Login",
"mssql.connectionOptions.authType.categoryValues.integrated": "Windows Authentication",
"mssql.connectionOptions.authType.categoryValues.azureMFA": "Azure Active Directory - Universal with MFA support",
"mssql.connectionOptions.authType.categoryValues.activeDirectoryPassword": "Active Directory - Password",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the "best" name we have for this option? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want a better name! Have any suggestions?

@adsbot adsbot bot added the Stale PR label Dec 16, 2019
@hummerpj
Copy link

Hi all,

Any plans to merge this soon? Would really love to see this land in ADS.

Thank you!

@adsbot adsbot bot removed the Stale PR label Jan 24, 2020
@kburtram
Copy link
Member

@hummerpj I think there were a couple issues we needed to track down before we can merge this.
@aaomidi can provide better details when he's back in the office next week. I'm not sure if this will make Feb release, or be held off for March release.

@arpishah2
Copy link

arpishah2 commented Jan 27, 2020

Hello,
Seems the changes are approved. Can this be merged before March?
Have been waiting for this to get merged. :-) Thanks!

@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 28, 2020

This is on my plate on things to tackle. @abist has been working on getting this working in the mssql vscode extension. I'll work with them to get this onto ADS as well.

@aaomidi aaomidi self-assigned this Jan 28, 2020
@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 28, 2020

Unfortunately this is going to be a no-fix: AzureAD/azure-activedirectory-library-for-dotnet#482

Looks like we're just going to have to stick to azure authentication.

@aaomidi aaomidi closed this Jan 28, 2020
@aaomidi
Copy link
Contributor Author

aaomidi commented Jan 28, 2020

Reverting: microsoft/sqltoolsservice#915

@aaomidi aaomidi deleted the amir/activeDirectoryPasswordAuthentication branch January 28, 2020 21:01
@hummerpj
Copy link

hummerpj commented Feb 2, 2020

I read through most of that thread and I am not sure I understand why it can't be supported.

Can't it be updated to MSAL.NET and supported through that?

It's disappointing that other applications on OSX are capable of accepting active directory username/password yet the main Microsoft applications can not.

Unfortunately, we are stuck using AD to access our DBs given the enterprise environment we are in. I presume, based on all the threads on this topic, that many others are stuck in a similar situation.

I appreciate the follow-up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants