Revert "Support active directory pwd authentication" #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b786a14.
Charles-Gagnon
approved these changes
Jan 28, 2020
|
@aaomidi This still something you want to get in? |
Charles-Gagnon
deleted the
revert-899-amir/ActiveDirectoryPasswordAuthentication
branch
smartguest
added a commit
that referenced
this pull request
Jul 16, 2021
* Added handling for deleting problematic rows * minor formatting changes * Null checks and executereader implemented * minor formatting * Fix for column deletion for text * minor space format * more format changes * Removal of top 200 and change of text comparison * space fix * minor commit * Added new tests for single clause * simplified regex * spacing fix * some polish for RowEditBaseTests * space fix * loc update (#914) * loc update * loc updates * Warning for multiple delete (#931) * Fix for multiple delete bug * minor space removal * removed catch error in RowDelete * small optimizations * space adding * WIP on creating test * Some cleanup * removed spaces * Fix for verifytext * Added check for command format correctness. * tidying up * added working test for command exception * simplification of TestDbDataReader getint * Corrections made * spacing and naming issues * minor space * one more space issue * Revert "Support ActiveDirectoryPassword authentication (#899)" (#915) This reverts commit b786a14. * revert changes to connectionService * fix for asserts * fix clauses Co-authored-by: khoiph1 <khoiph@microsoft.com> Co-authored-by: Amir Omidi <amir@aaomidi.com>
nofield
pushed a commit
that referenced
this pull request
Jul 19, 2022
* Added handling for deleting problematic rows * minor formatting changes * Null checks and executereader implemented * minor formatting * Fix for column deletion for text * minor space format * more format changes * Removal of top 200 and change of text comparison * space fix * minor commit * Added new tests for single clause * simplified regex * spacing fix * some polish for RowEditBaseTests * space fix * loc update (#914) * loc update * loc updates * Warning for multiple delete (#931) * Fix for multiple delete bug * minor space removal * removed catch error in RowDelete * small optimizations * space adding * WIP on creating test * Some cleanup * removed spaces * Fix for verifytext * Added check for command format correctness. * tidying up * added working test for command exception * simplification of TestDbDataReader getint * Corrections made * spacing and naming issues * minor space * one more space issue * Revert "Support ActiveDirectoryPassword authentication (#899)" (#915) This reverts commit b786a14. * revert changes to connectionService * fix for asserts * fix clauses Co-authored-by: khoiph1 <khoiph@microsoft.com> Co-authored-by: Amir Omidi <amir@aaomidi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No point having code we can't use: AzureAD/azure-activedirectory-library-for-dotnet#482