-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C# grpc] Include grpc generated files automatically. #630
Closed
Closed
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a050655
[C# grpc] Include grpc generated files automatically.
hcoona 0bf999d
[C# grpc] Include grpc generated files only for the one with options …
hcoona 952b3f7
[C# grpc] Try fix build.
hcoona 821245e
[C# grpc] Exclude the manual imported generated *_grpc.cs files.
hcoona 034690b
Travis use msbuild instead of xbuild because it's deprecated.
hcoona ddc717e
Exclude Compiler.vcxproj from cs/cs.sln for Travis CI.
hcoona 1bb45d8
[C# grpc] Fix the situation BondOptions contains --grpc option.
hcoona a34707b
[C# grpc] Separate into 2 situations: BondOptions contains --grpc for…
hcoona 6d8229e
Merge remote-tracking branch 'upstream/master'
hcoona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -127,6 +127,12 @@ | |
<DependentUpon>%(BondCodegen.Identity)</DependentUpon> | ||
</_BondGeneratedFiles> | ||
|
||
<_BondGeneratedFiles Include="@(BondCodegen -> '$(BondOutputDirectory)\%(FileName)_grpc.cs')" | ||
Condition="$([System.String]::new('%(BondCodegen.Options)').Contains('--grpc'))"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also needs to handle the case when the property |
||
<AutoGen>true</AutoGen> | ||
<DependentUpon>%(BondCodegen.Identity)</DependentUpon> | ||
</_BondGeneratedFiles> | ||
|
||
<_BondGeneratedFileNames Include="@(_BondGeneratedFiles)"/> | ||
<Compile Include="@(_BondGeneratedFileNames)" /> | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to msbuild is understandable, but shouldn't be part of this PR. Can you revert the xbuild to msbuild changes from this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xbuild didn't get the property function work fine, so I have to switch to msbuild here. I'll make another PR for the msbuild switching.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chwarr Please see PR #633