[C# grpc] Include grpc generated files automatically. #630
Conversation
|
|
.travis.yml
Outdated
| - if [ "$FLAVOR" == "cs" ]; then xbuild /p:Configuration=Fields cs/cs.sln; fi | ||
| # exclude the Compiler.vcxproj from cs/cs.sln on Linux (xbuild ignore it with a warning but msbuild fail on it) | ||
| - if [ "$FLAVOR" == "cs" ]; then sed '/21E175D5-BBDD-4B63-8FB7-38899BF2F9D1/d' cs/cs.sln > cs/cs_no_cpp.sln; fi | ||
| - if [ "$FLAVOR" == "cs" ]; then msbuild /p:Configuration=Debug cs/cs_no_cpp.sln; fi |
There was a problem hiding this comment.
Switching to msbuild is understandable, but shouldn't be part of this PR. Can you revert the xbuild to msbuild changes from this PR?
There was a problem hiding this comment.
xbuild didn't get the property function work fine, so I have to switch to msbuild here. I'll make another PR for the msbuild switching.
cs/build/nuget/Common.targets
Outdated
| @@ -127,6 +127,12 @@ | |||
| <DependentUpon>%(BondCodegen.Identity)</DependentUpon> | |||
| </_BondGeneratedFiles> | |||
|
|
|||
| <_BondGeneratedFiles Include="@(BondCodegen -> '$(BondOutputDirectory)\%(FileName)_grpc.cs')" | |||
| Condition="$([System.String]::new('%(BondCodegen.Options)').Contains('--grpc'))"> | |||
There was a problem hiding this comment.
This also needs to handle the case when the property $(BondOptions) contains "--grpc". Note that $(BondOptions) is only used for BondCodegen items that don't have overridden Options metadata. One of the examples can be changed to use $(BondOptions) as a test for this behavior.
|
Go ahead and add new commits (instead of rebasing). That will make follow ups to the PR easier. One of the maintainers can squash/rebase for the final merge. |
… no-overridden BondCodegen items, the BondCodegen.Options contains --grpc.
|
Since this relies on MSBuild functionality, it would, when released, break anyone using xbuild. Let me see whether I can assess how large that population is. (I suspect that such a breaking change would be OK.) |
|
Requiring MSBuild is fine, so we can rely on MSBuild-only functionality. After #633 is finished, this PR can be resumed atop those changes. |
Update the MSBuild codegen targets to automatically include the generated _grpc.cs files if --grpc is passed to gbc. Fixes microsoft#448 Closes microsoft#630
* The MSBuild codegen targets now detect --structs=false and skip automatic compilation of the non-existent `_types.cs` files. * Added a gRPC example that show how to use a shared type assembly between a client and service. Fixes microsoft#448 Closes microsoft#630
* Two cases need to be handeled: $BondOptions contains --grpc for no-overridden BondCodegen items, the %BondCodegen.Options contains --grpc. Also --grpc=false needs to be handled in both cases. * Updated the examples ad tests to no longer include the generated *_grpc.cs files. Fixes microsoft#448 Closes microsoft#630
This change would include "%(filename)_grpc.cs" as well as "%(filename)_types.cs" only for the
BondCodegenitems with additionOptionsmeta and the meta contains '--grpc'.