Automatically compile _grpc.cs when --grpc is passed #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Two cases need to be handeled: $BondOptions contains --grpc for no-overridden BondCodegen items, the %BondCodegen.Options contains --grpc. Also --grpc=false needs to be handled in both cases. * Updated the examples ad tests to no longer include the generated *_grpc.cs files. Fixes microsoft#448 Closes microsoft#630
chwarr
force-pushed
the
chwarr/grpc-msbuild-gen
branch
3 times, most recently
from
092bb21
to
48f937e
Compare
* The MSBuild codegen targets now detect --structs=false and skip automatic compilation of the non-existent `_types.cs` files. * Added a gRPC example that show how to use a shared type assembly between a client and service.
chwarr
force-pushed
the
chwarr/grpc-msbuild-gen
branch
from
48f937e
to
12dd01e
Compare
lalo
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please rebase when merging.
@hcoona: I merged #630 manually into this PR and then added handling for
--structs=falseon top of that to get the shared-types-assembly example working. Please leave #630 open. When this is merged in, it will be closed automatically with a pointer to the final commit that the PR results in.commit 0e5aa58
Author: Christopher Warrington
AuthorDate: Fri Oct 20 18:58:59 2017 -0700
Commit: Christopher Warrington
CommitDate: Mon Oct 23 18:31:41 2017 -0700
commit 61d9644
Author: Shuai Zhang
AuthorDate: Mon Oct 23 14:49:46 2017 -0700
Commit: Christopher Warrington
CommitDate: Mon Oct 23 18:31:33 2017 -0700