Update actions/upload-artifact to v4 #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseParsons
commented
Sep 16, 2024
| @@ -81,7 +81,7 @@ jobs: | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
i feel like this should not continue on error... the check failed on the following step because the sarif was not present
There was a problem hiding this comment.
proposed in #67
JesseParsons
commented
Sep 16, 2024
| @@ -69,7 +69,7 @@ jobs: | |||
| if: runner.os == 'Windows' | |||
|
|
|||
| - name: Run eslint | |||
| run: npx eslint | |||
| run: npx eslint@7.32.0 | |||
There was a problem hiding this comment.
this should use the version in package.json... i'm not sure why we're installing the latest packages above and not using the ones defined in the repo
taurheim
approved these changes
Sep 17, 2024
|
Hi @JesseParsons, I merged this one #58 with other updates, so I'll close this one. You're still listed as co-author on relevant commits of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.