Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/upload-artifact to v4 #55

Closed
wants to merge 4 commits into from
Closed

Update actions/upload-artifact to v4 #55

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
701bcd9
Update actions/upload-artifact to v4
JesseParsons Sep 16, 2024
191ff7a
Add missed change from #43
JesseParsons Sep 16, 2024
ec3b080
Explicit version
JesseParsons Sep 16, 2024
9de9d2a
Unique name
JesseParsons Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/E2E integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: E2E integration
on:
push:
branches: [main]
pull_request_target:
pull_request:
branches: [main, release/vNext]

env:
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
if: runner.os == 'Windows'

- name: Run eslint
run: npx eslint
run: npx eslint@7.32.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should use the version in package.json... i'm not sure why we're installing the latest packages above and not using the ones defined in the repo

-c node_modules/@microsoft/eslint-plugin-sdl/config/required.js
../${{env.PROJECT}}/${{env.FOLDER_TO_SCAN}}/
--ext .js
Expand All @@ -81,8 +81,8 @@ jobs:
continue-on-error: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like this should not continue on error... the check failed on the following step because the sarif was not present

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposed in #67


- name: Upload eslint results as artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: eslint-result
name: eslint-result-${{ matrix.os }}
path: ${{env.PROJECT}}/eslint-result-${{ matrix.os }}-${{github.run_id}}.sarif
if-no-files-found: error
Loading