Consolidate Cluster Slot Verification #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
from
f325817 to
d6dbc7c
Compare
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
2 times, most recently
from
b144d93 to
90b4aee
Compare
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
3 times, most recently
from
1ca4c44 to
e8b2594
Compare
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
from
ce8b02d to
9793fb4
Compare
TalZaccai
reviewed
Aug 7, 2024
TalZaccai
requested changes
Aug 7, 2024
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
4 times, most recently
from
5d81a85 to
106a23b
Compare
TalZaccai
requested changes
Aug 15, 2024
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
2 times, most recently
from
da7460e to
f3d3175
Compare
TalZaccai
approved these changes
Aug 15, 2024
vazois
force-pushed
the
vazois/slot-check-after-parsing
branch
from
572e5de to
e897c76
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first attempt of moving slot verification outside the command execution methods