Skip test on Windows before 19H1 #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Test_RunPodSandbox_MultipleContainersSameVhd_WCOW test does not work prior to 19H1. In those versions, HcsFormatWritableLayerVhd requires the VHD to be mounted prior to calling, which we don't do currently. Because of this, we are unable to create a VHD to use for the test. This fixes the issue by simply skipping the test on the affected OS versions. We could potentially resolve this in the future by adding more code to do the VHD mount ourselves, but this is a quick fix for moment. We will still have test coverage of this functionality on 19H1, so this shouldn't be a big issue. Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Test_RunPodSandbox_MultipleContainersSameVhd_WCOW test does not work
prior to 19H1. In those versions, HcsFormatWritableLayerVhd requires the
VHD to be mounted prior to calling, which we don't do currently. Because
of this, we are unable to create a VHD to use for the test.
This fixes the issue by simply skipping the test on the affected OS
versions. We could potentially resolve this in the future by adding
more code to do the VHD mount ourselves, but this is a quick fix for
moment.
We will still have test coverage of this functionality on 19H1, so this
shouldn't be a big issue.
Signed-off-by: Kevin Parsons kevpar@microsoft.com