Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test on Windows before 19H1 #810

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Skip test on Windows before 19H1 #810

merged 1 commit into from
Apr 21, 2020

Commits on Apr 21, 2020

  1. Skip test on Windows before 19H1 

    The Test_RunPodSandbox_MultipleContainersSameVhd_WCOW test does not work
prior to 19H1. In those versions, HcsFormatWritableLayerVhd requires the
VHD to be mounted prior to calling, which we don't do currently. Because
of this, we are unable to create a VHD to use for the test.

This fixes the issue by simply skipping the test on the affected OS
versions. We could potentially resolve this in the future by adding
more code to do the VHD mount ourselves, but this is a quick fix for
moment.

We will still have test coverage of this functionality on 19H1, so this
shouldn't be a big issue.

Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
    @kevpar
    kevpar committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    16766c9 View commit details
    Browse the repository at this point in the history