Add inverted group mask #608
Conversation
| @@ -73,13 +78,31 @@ export default class UserMaskTest extends Test { | |||
| } | |||
| }); | |||
|
|
|||
| const notRedIcon = MRE.Actor.Create(this.app.context, { | |||
There was a problem hiding this comment.
lint is complaining:
C:\code\Microsoft\mixed-reality-extension-sdk\packages\functional-tests\src\tests\user-mask-test.ts
81:9 warning 'notRedIcon' is assigned a value but never used @typescript-eslint/no-unused-vars
115:9 warning 'notBlueIcon' is assigned a value but never used @typescript-eslint/no-unused-vars
| name: 'notRedIcon', | ||
| parentId: root.id, | ||
| appearance: { | ||
| enabled: new MRE.InvertedGroupMask(this.app.context, ['red', 'default']), |
There was a problem hiding this comment.
InvertedGroupMask [](start = 22, length = 17)
Does this mean not in the default group as well? Or is every user alway in the default group?
There was a problem hiding this comment.
Not in the default group, correct.
There was a problem hiding this comment.
To clarify: every user who has no other groups assigned is in the "default" group. So if "default" is in an inverted group mask, then those users will not see the given object.
In reply to: 437673473 [](ancestors = 437673473)
There was a problem hiding this comment.
So then it is possible to use the default group for filtering now as well since you can set and object for the "not default group"?
In reply to: 437683618 [](ancestors = 437683618,437673473)
There was a problem hiding this comment.
You could always use the default group for filtering. Remember, the default group is not all users, it's only users with no other groups assigned. Just now you can apply inverted semantics. It's just like any other group.
In reply to: 437688309 [](ancestors = 437688309,437683618,437673473)
Add the concept of a GroupMask containing everything but the specified groups.