This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
Add inverted group mask #608
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,5 @@ | |
*/ | ||
|
||
export * from './groupMask'; | ||
export * from './invertedGroupMask'; | ||
export * from './user'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/*! | ||
* Copyright (c) Microsoft Corporation. All rights reserved. | ||
* Licensed under the MIT License. | ||
*/ | ||
import { GroupMask } from './groupMask'; | ||
|
||
/** | ||
* A collection of user group IDs. Unlike in [[GroupMask]], users in these groups are **excluded** from this mask | ||
* instead of included. | ||
*/ | ||
export class InvertedGroupMask extends GroupMask { | ||
/** @hidden */ | ||
public packed() { | ||
return ~super.packed(); | ||
} | ||
|
||
/** @hidden */ | ||
public setPacked(value: number) { | ||
super.clear(); | ||
const mapping = this.context.internal.userGroupMapping; | ||
|
||
if (!this.allowDefault) { | ||
value = value & ~this.getOrAddMapping('default'); | ||
} | ||
for (const name of Object.keys(mapping)) { | ||
if ((value & this.getOrAddMapping(name)) === 0) { | ||
super.add(name); | ||
} | ||
} | ||
if (this.changedCallback) { | ||
this.changedCallback(this); | ||
} | ||
} | ||
|
||
/** Convert this from a mask containing everything but these groups to a mask containing only these groups. */ | ||
public invert() { | ||
return new GroupMask(this.context, this); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean not in the default group as well? Or is every user alway in the default group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in the default group, correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify: every user who has no other groups assigned is in the "default" group. So if "default" is in an inverted group mask, then those users will not see the given object.
In reply to: 437673473 [](ancestors = 437673473)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then it is possible to use the default group for filtering now as well since you can set and object for the "not default group"?
In reply to: 437683618 [](ancestors = 437683618,437673473)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could always use the default group for filtering. Remember, the default group is not all users, it's only users with no other groups assigned. Just now you can apply inverted semantics. It's just like any other group.
In reply to: 437688309 [](ancestors = 437688309,437683618,437673473)