Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Provide related information to diagnostics #48

Merged
merged 2 commits into from
Dec 17, 2019

Conversation

spahnke
Copy link
Contributor

@spahnke spahnke commented Oct 7, 2019

Adds related information to a diagnostic if the TypeScript service reports any. An example would be Did you forget to use 'await'? in the following code.

function foo(bar: number) {}

function bar() {
    const baz = Promise.resolve(1);
    foo(baz);
    //  ~~~ Related: Did you forget to use 'await'?
}

@orta
Copy link
Contributor

orta commented Oct 7, 2019

Thanks! I'll get this merged into our nightly typescript builds

@orta
Copy link
Contributor

orta commented Oct 9, 2019

Nice one, this works well - Anders asked about the implement interface fixit yesterday

Screen Shot 2019-10-08 at 7 40 31 PM

@alexdima
Copy link
Member

alexdima commented Dec 17, 2019

Thank you, works nicely ! ❤️

@alexdima alexdima added this to the December 2019 milestone Dec 17, 2019
@alexdima alexdima merged commit 2bbb4ed into microsoft:master Dec 17, 2019
@spahnke spahnke deleted the related-information branch December 19, 2019 19:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants