This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#2392
Before this change the
ts.Diagnostic
objects internal to TypeScript were mutated. This was fine when thefile
property was cleared completely, but broke with #74 where we kept thefileName
. The methodcomputeLineStarts
intypescriptServices.js
then gets a parameter which isundefined
(the source text of the file) causing the exception in the issue.I tested with the code from the issue, the use-case from #74 and the original use-case from #48.
~line 8874 in
out/amd/lib/typescriptServices.js