Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

TsunFeng · 2024-08-14T09:42:03Z

Description

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

codecov-commenter · 2024-08-14T09:59:21Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 1.59%. Comparing base (23f8354) to head (2e32b09).

Files with missing lines	Patch %	Lines
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c	0.00%	7 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           dev/202405    #1106      +/-   ##
==============================================
- Coverage        1.59%    1.59%   -0.01%     
==============================================
  Files            1448     1448              
  Lines          362490   362500      +10     
  Branches         5632     5632              
==============================================
  Hits             5776     5776              
- Misses         356607   356617      +10     
  Partials          107      107

Flag	Coverage Δ
MdeModulePkg	`0.68% <ø> (ø)`
MdePkg	`5.42% <ø> (ø)`
NetworkPkg	`0.55% <0.00%> (-0.01%)`	⬇️
PolicyServicePkg	`30.41% <ø> (ø)`
UefiCpuPkg	`4.73% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockAcpiSystemDescriptionTable.h

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h

MdePkg/Test/Mock/Library/GoogleTest/Protocol/MockAcpiSystemDescriptionTable.cpp

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h

…27.12 (microsoft#1133) Updates the requirements on [edk2-pytool-extensions](https://github.com/tianocore/edk2-pytool-extensions) to permit the latest version. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

This reverts commit d74b9cf.

Includes changes across the repo for the following CodeQL rules: - cpp/comparison-with-wider-type - cpp/overflow-buffer - cpp/redundant-null-check-param - cpp/uselesstest Co-authored-by: Taylor Beebe <tabeebe@microsoft.com> Co-authored-by: pohanch <125842322+pohanch@users.noreply.github.com> Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com> Co-authored-by: Oliver Smith-Denny <osde@linux.microsoft.com> Co-authored-by: Sean Brogan <sean.brogan@microsoft.com> Co-authored-by: Aaron <105021049+apop5@users.noreply.github.com>

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h

## Description Add mocks from 2311 Cherry picked and squashed the following commits: a5ba951 5aa1be5 - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested in 202311 CI ## Integration Instructions N/A Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com> Co-authored-by: v-sbolisetti <v-sbolisetti@microsoft.com> Co-authored-by: YiTa-AMI <v-yitawu@microsoft.com>

…irmwareVolume2 and AcpiSystemDescriptionTable protocol

…criptionTable.h Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: TsunFeng <v-tshuang@microsoft.com>

Co-authored-by: Aaron <105021049+apop5@users.noreply.github.com> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>

…icrosoft#1135) synced local file(s) with [microsoft/mu_devops](https://github.com/microsoft/mu_devops). 🤖: View the [Repo File Sync Configuration File](https://github.com/microsoft/mu_devops/blob/main/.sync/Files.yml) to see how files are synced. --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#10846265775](https://github.com/microsoft/mu_devops/actions/runs/10846265775) Signed-off-by: Project Mu UEFI Bot <uefibot@microsoft.com>

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h

github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Aug 14, 2024

This comment was marked as outdated.

Sign in to view

makubacki reviewed Aug 15, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Library/MockUefiLib.h Outdated Show resolved Hide resolved

makubacki reviewed Aug 15, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockAcpiSystemDescriptionTable.h Outdated Show resolved Hide resolved

makubacki reviewed Aug 15, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockAcpiSystemDescriptionTable.h Outdated Show resolved Hide resolved

makubacki reviewed Aug 15, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

makubacki reviewed Aug 15, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

VivianNK reviewed Aug 23, 2024

View reviewed changes

MdePkg/Test/Mock/Library/GoogleTest/Protocol/MockAcpiSystemDescriptionTable.cpp Outdated Show resolved Hide resolved

TsunFeng requested review from VivianNK and makubacki August 27, 2024 04:14

VivianNK reviewed Aug 27, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

TsunFeng requested a review from VivianNK August 28, 2024 10:23

VivianNK approved these changes Aug 28, 2024

View reviewed changes

VivianNK requested a review from apop5 August 28, 2024 18:26

This comment was marked as resolved.

Sign in to view

apop5 approved these changes Sep 3, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

apop5 and others added 2 commits September 10, 2024 15:49

Revert "MdeModulePkg: CodeQL Fixes."

91a2538

This reverts commit d74b9cf.

This comment was marked as resolved.

Sign in to view

apop5 reviewed Sep 11, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

apop5 reviewed Sep 11, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

apop5 reviewed Sep 11, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

apop5 reviewed Sep 11, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

makubacki reviewed Sep 11, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Show resolved Hide resolved

makubacki approved these changes Sep 11, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

TsunFeng changed the base branch from release/202311 to dev/202405 September 13, 2024 01:55

github-actions bot added the language:python Pull requests that update Python code label Sep 13, 2024

TsunFeng changed the base branch from dev/202405 to release/202311 September 13, 2024 02:24

github-actions bot removed the language:python Pull requests that update Python code label Sep 13, 2024

TsunFeng and others added 8 commits September 13, 2024 11:04

Add mock functions under MockUefiLib and Create Mock for AcpiTable, F…

a70a3c7

…irmwareVolume2 and AcpiSystemDescriptionTable protocol

Update MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockAcpiSystemDes…

16ee9ad

…criptionTable.h Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: TsunFeng <v-tshuang@microsoft.com>

Update MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockAcpiSystemDes…

11487f9

…criptionTable.h Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: TsunFeng <v-tshuang@microsoft.com>

For all header guards add the postfix.

e325b73

Remove all the protocol cpp for new guidelines

479a432

Remove redundant extern in H file

cbc3c44

Apply edk2 naming conventions

6258fbe

Co-authored-by: Aaron <105021049+apop5@users.noreply.github.com> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>

Fix uncrustify build error

aea842e

TsunFeng force-pushed the personal/TsunFeng/NuvotonSioAcpiGT branch from 8cd3cbd to aea842e Compare September 13, 2024 05:35

TsunFeng changed the base branch from release/202311 to release/202405 September 13, 2024 05:36

github-actions bot added the language:python Pull requests that update Python code label Sep 13, 2024

Merge branch 'release/202405' into personal/TsunFeng/NuvotonSioAcpiGT

a22a960

github-actions bot removed the language:python Pull requests that update Python code label Sep 13, 2024

This comment was marked as resolved.

Sign in to view

uefibot and others added 2 commits September 13, 2024 14:25

Merge branch 'release/202405' into personal/TsunFeng/NuvotonSioAcpiGT

84dc82a

This comment was marked as resolved.

Sign in to view

TsunFeng changed the base branch from release/202405 to dev/202405 September 19, 2024 01:48

Merge branch 'dev/202405' into personal/TsunFeng/NuvotonSioAcpiGT

f32899f

This comment was marked as resolved.

Sign in to view

VivianNK reviewed Sep 19, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

VivianNK reviewed Sep 19, 2024

View reviewed changes

MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolume2.h Outdated Show resolved Hide resolved

VivianNK approved these changes Sep 19, 2024

View reviewed changes

Remove extra newlines in MockFirmwareVolume2.h

2e32b09

VivianNK self-assigned this Sep 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

TsunFeng commented Aug 14, 2024

This comment was marked as outdated.

codecov-commenter commented Aug 14, 2024 •

edited

Loading

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

Are you sure you want to change the base?

Add mock functions under MockUefiLib and Create Mock for AcpiTable, FirmwareVolume2 and AcpiSystemDescriptionTable protocol #1106

Conversation

TsunFeng commented Aug 14, 2024

Description

How This Was Tested

Integration Instructions

This comment was marked as outdated.

codecov-commenter commented Aug 14, 2024 • edited Loading

Codecov Report

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

codecov-commenter commented Aug 14, 2024 •

edited

Loading