This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix the issue that date nanoseconds does not work under macOS #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icrosoft#1412) * Eject from react-scripts-ts-antd * test whether it can pass CI without ugilfy * temporarily disable uglify
chicm-ms
reviewed
Aug 9, 2019
`eval ${localTrailConfig.command} 2>${path.join(workingDirectory, 'stderr')}`, | ||
`echo $? \`date +%s%3N\` >${path.join(workingDirectory, '.nni', 'state')}`); | ||
script.push(`eval ${localTrailConfig.command} 2>${path.join(workingDirectory, 'stderr')}`); | ||
if (process.platform == 'darwin') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use "===" instead of "=="
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
liuzhe-lz
approved these changes
Aug 9, 2019
QuanluZhang
approved these changes
Aug 12, 2019
* fix bug for duplicated final results
* update doc: rename button "download" to "view"
fix bugs about sort & concurrency & multi-phase
* change authFile to local path
* update nas doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1416