This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add a field to the job summary to indicate if at least one bug was created. #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3441 +/- ##
==========================================
+ Coverage 39.95% 47.14% +7.18%
==========================================
Files 303 167 -136
Lines 37724 22918 -14806
Branches 1738 0 -1738
==========================================
- Hits 15073 10804 -4269
+ Misses 22330 12114 -10216
+ Partials 321 0 -321 |
chkeita
force-pushed
the
store_notification
branch
4 times, most recently
from
ab57da5
to
c983ac6
Compare
return the list of job created in the job_summary
chkeita
force-pushed
the
store_notification
branch
from
17a0f6b
to
bec1df9
Compare
chkeita
changed the title
tevoinea
reviewed
Oct 12, 2023
|
|
||
| public IAsyncEnumerable<AdoNotificationEntry> GetByJobId(Guid jobId); | ||
|
|
||
| public Async.Task<bool> WasNotfied(Guid jobId); |
tevoinea
approved these changes
Oct 12, 2023
tevoinea
reviewed
Oct 30, 2023
|
|
||
| public record AdoNotificationEntry( | ||
| [PartitionKey] Guid JobId, | ||
| [RowKey] int Id, |
There was a problem hiding this comment.
A work item ID needs an associated ADO org. We should store the ADO org here as well, otherwise it'll be very painful to figure out which org it was created in. Could we also name this WorkItemId so we know what the ID is for?
chkeita
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a field to the job summary to indicate if at least one bug was created.
closes #3548