This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Add a field to the job summary to indicate if at least one bug was created. #3441
Closed
Closed
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bec1df9
storing the ado notification title and work item id
chkeita 08788fe
remove bug list and add has_bugs
chkeita 22e8651
fix test
chkeita 835d55a
Merge branch 'main' into store_notification
chkeita 6919dba
Merge branch 'main' into store_notification
chkeita 4e41131
Merge branch 'main' into store_notification
chkeita 0728689
Merge branch 'main' into store_notification
chkeita 8da70e5
Merge branch 'main' into store_notification
chkeita 3cc48d9
report CrashReported instead
chkeita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
src/ApiService/ApiService/onefuzzlib/AdoNotificationEntryOperation.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
using ApiService.OneFuzzLib.Orm; | ||
using Microsoft.Extensions.Logging; | ||
namespace Microsoft.OneFuzz.Service; | ||
|
||
public interface IAdoNotificationEntryOperations : IOrm<AdoNotificationEntry> { | ||
|
||
public IAsyncEnumerable<AdoNotificationEntry> GetByJobId(Guid jobId); | ||
|
||
public Async.Task<bool> WasNotfied(Guid jobId); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: typo |
||
|
||
} | ||
public class AdoNotificationEntryOperations : Orm<AdoNotificationEntry>, IAdoNotificationEntryOperations { | ||
|
||
public AdoNotificationEntryOperations(ILogger<AdoNotificationEntryOperations> log, IOnefuzzContext context) | ||
: base(log, context) { | ||
|
||
} | ||
|
||
public IAsyncEnumerable<AdoNotificationEntry> GetByJobId(Guid jobId) { | ||
return QueryAsync(filter: Query.PartitionKey(jobId.ToString())); | ||
} | ||
|
||
public async Async.Task<bool> WasNotfied(Guid jobId) { | ||
return await QueryAsync(filter: Query.PartitionKey(jobId.ToString()), maxPerPage: 1).AnyAsync(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
src/ApiService/IntegrationTests/Fakes/TestAdoNotificationEntryOperations.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
using Microsoft.Extensions.Logging; | ||
using Microsoft.OneFuzz.Service; | ||
namespace IntegrationTests.Fakes; | ||
|
||
public sealed class TestAdoNotificationEntryOperations : AdoNotificationEntryOperations { | ||
public TestAdoNotificationEntryOperations(ILogger<AdoNotificationEntryOperations> log, IOnefuzzContext context) | ||
: base(log, context) { } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A work item ID needs an associated ADO org. We should store the ADO org here as well, otherwise it'll be very painful to figure out which org it was created in. Could we also name this
WorkItemId
so we know what the ID is for?