Skip to content

Commit

Permalink
cherry-pick(#29271): Revert "chore: remove fake error from expect c…
Browse files Browse the repository at this point in the history
…alls (#28112)" (#29296)

This PR cherry-picks the following commits:

- 622153d

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
playwrightmachine and github-actions[bot] authored Feb 1, 2024
1 parent 7a72adc commit 414affa
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ export class FrameDispatcher extends Dispatcher<Frame, channels.FrameChannel, Br
const result = await this._frame.expect(metadata, params.selector, { ...params, expectedValue });
if (result.received !== undefined)
result.received = serializeResult(result.received);
if (result.matches === params.isNot)
metadata.error = { error: { name: 'Expect', message: 'Expect failed' } };
return result;
}
}

0 comments on commit 414affa

Please sign in to comment.