Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: remove fake error from expect calls (#28112)" #29271

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Revert "chore: remove fake error from expect calls (#28112)" #29271

merged 1 commit into from
Jan 31, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jan 31, 2024 •
edited
Loading

This reverts commit 2c3955a.

Relates microsoft/playwright-python#2258

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › watch.spec.ts:607:5 › should run CT on indirect deps change

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

21233 passed, 577 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 622153d into microsoft:main Jan 31, 2024
29 of 30 checks passed
github-actions bot added a commit that referenced this pull request Feb 1, 2024
@github-actions
cherry-pick(#29271): Revert "chore: remove fake error from expect c…
e969797 
…alls (#28112)"
mxschmitt pushed a commit that referenced this pull request Feb 1, 2024
@playwrightmachine @github-actions
cherry-pick(#29271): Revert "chore: remove fake error from expect c…
414affa 
…alls (#28112)" (#29296)

This PR cherry-picks the following commits:

- 622153d

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @dgozman