feat(screencast): add expreimental public API on context #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
requested review from
aslushnikov and
pavelfeldman
and removed request for
aslushnikov
pavelfeldman
reviewed
Sep 4, 2020
docs/api.md
Outdated
| @@ -345,6 +348,30 @@ console.log(await page.evaluate('location.href')); | |||
|
|
|||
| > **NOTE** Use [`page.waitForLoadState([state[, options]])`](#pagewaitforloadstatestate-options) to wait until the page gets to a particular state (you should not need it in most cases). | |||
|
|
|||
| #### browserContext._disableScreencast() | |||
There was a problem hiding this comment.
Let's land them as commented out for now. <!-- -->
There was a problem hiding this comment.
Removed these. Added options.
yury-s
force-pushed
the
screencast-api
branch
from
9dc430a
to
a868220
Compare
yury-s
force-pushed
the
screencast-api
branch
from
a868220
to
7fcb88e
Compare
pavelfeldman
approved these changes
Sep 5, 2020
src/dispatchers/pageDispatcher.ts
Outdated
| @@ -65,6 +66,7 @@ export class PageDispatcher extends Dispatcher<Page, channels.PageInitializer> i | |||
| })); | |||
| page.on(Page.Events.RequestFinished, request => this._dispatchEvent('requestFinished', { request: RequestDispatcher.from(scope, request) })); | |||
| page.on(Page.Events.Response, response => this._dispatchEvent('response', { response: new ResponseDispatcher(this._scope, response) })); | |||
| page.on(Page.Events.ScreencastStarted, screencast => this._dispatchEvent('videoStarted', { video: new VideoDispatcher(this._scope, screencast) })); | |||
There was a problem hiding this comment.
Nit: we should narrow down the scopes as much as we can (page in this case)
There was a problem hiding this comment.
The video can survive the page and finish after it has closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1158