[0.64] Pull in upstream fixes to expose hover props on Pressable #884 #885
Conversation
[pull] master from microsoft:master
#2) Co-authored-by: Ryan Linton <ryanlntn@gmail.com>
[pull] master from microsoft:master
[pull] master from microsoft:master
* Deprecated api (microsoft#853) * Remove deprecated/unused context param * Update a few Mac deprecated APIs * Packing RN dependencies, hermes and ignoring javadoc failure, (microsoft#852) * Ignore javadoc failure * Bringing few more changes from 0.63-stable * Fixing a patch in engine selection * Fixing a patch in nuget spec * Fixing the output directory of nuget pack * Packaging dependencies in the nuget * Fix onMouseEnter/onMouseLeave callbacks not firing on Pressable (microsoft#855) * add pull yml * match handleOpenURLNotification event payload with iOS (microsoft#755) (#2) Co-authored-by: Ryan Linton <ryanlntn@gmail.com> * fix mouse evetns on pressable * delete extra yml from this branch * Add macOS tags * reorder props to have onMouseEnter/onMouseLeave always be before onPress Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <ryanlntn@gmail.com> * Grammar fixes. (microsoft#856) Updates simple grammar issues. Co-authored-by: Nick Trescases <42704557+ntre@users.noreply.github.com> Co-authored-by: Anandraj <anandrag@microsoft.com> Co-authored-by: Saad Najmi <saadnajmi2@gmail.com> Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com> Co-authored-by: Ryan Linton <ryanlntn@gmail.com> Co-authored-by: Muhammad Hamza Zaman <mh.zaman.4069@gmail.com>
* Add the missing android folder to files in package.json * Fix for submit button disappear bug in comments Co-authored-by: Mayuresh Gharpure <Mayuresh.Gharpure@microsoft.com>
…bilityFocus on macOS
…essibility-focus-notification fix: Post NSAccessibilityLayoutChangedNotification when we call setAccessibilityFocus on macOS
Fixes for publishing from stable branches
* nullable compat * undo last nullable check * nullable compat
Summary: Several desktop forks (`react-native-macos`, `react-native-windows`, `react-native-web`) support mouse events, and while the stock Pressable component has the ability to support mouse events, it seems we aren't forwarding some props properly from Pressable -> Pressability. Pressability will calculate onMouseEnter / onMouseLeave event handlers based on the `onHoverIn/onHoverOut` callbacks passed into PressabilityConfig. https://github.com/facebook/react-native/blob/ad0d4534a751ed05f84ff971714c8f7a4d1deb3a/Libraries/Pressability/Pressability.js#L552 However, Pressable does not pass take in onHoverIn/onHoverOut props to pass to PressabilityConfig, so we can't take advantage of this functionality. This change should simply address that by passing the props through. <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Pressabel not passing hover props and event handlers to PressabilityConfig Pull Request resolved: facebook#32405 Test Plan: I fixed a similar issue in `react-native-macos` that I am now trying to contribute back upstream. microsoft#855 Reviewed By: yungsters Differential Revision: D31667737 Pulled By: sota000 fbshipit-source-id: f0bbe48302703bb2c45280d2afeec8d7a4586b6a
Saadnajmi
changed the title
|
|
This looks like a breaking change? Shouldnt we support the old property names (with warning) for a period of time to allow apps to transition? |
Right, I wanted opinions about that. The "old" property names (onMouseEnter/onMouseLeave) didn't actually work until #855 which was 22 days ago. I assume nobody has actually gone and used the old property names in the last 22 days. However, react-native-windows explicitly supports both for backwards compatibility, which is why I added @rectified95 / @NickGerleman to ask their opinions about supporting both. I can pull in the changes from react-native-windows to support both onMouseEnter/onMouseLeave AND onHoverIn/onHoverOut, but if nobody is using the former, we can reduce diffs by not supporting it. |
|
My opinion: |
It's available in the very latest 0.63.x release with #857 . I think it's safe to assume the only person possibly using it was me at the time. |
|
So it was in one dot release, maybe you can do the rename in 0.63 too.. So its not around for long. Otherwise people on 0.63 might start using it before switching to 0.64? |
|
@acoates-ms That's fair, I can make a 3rd PR to pull this into 0.63-stable as well. |
Rename directory for ship .so files to be ship instead of release
Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.13...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/packages/react-native-macos-init/tar-4.4.19 Bump tar from 4.4.13 to 4.4.19 in /packages/react-native-macos-init
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…rn/packages/react-native-macos-init/hosted-git-info-2.8.9 Bump hosted-git-info from 2.8.8 to 2.8.9 in /packages/react-native-macos-init
Add nullability type
* revert dev mode on ship builds * rctuicolor * remove unused variable * pod install
… upstream-pressable-hover
|
Closing in favor of #922 |
Same as #884 except targeting the 0.64-stable branch.