Change Accessible/Focusable Relationship to Default to #10569
Conversation
|
I feel like given the fact that almost all controls are focusable/accessible by default, this might be confusing for folks when they set focusable or accessible (but not both) to false, but the control remains focusable. @rozele would it be enough if we only have this behavior for the View component? |
|
yellow box should help with any confusion for new developers, although I'm still worried this will be a breaking change. E.g. even for us, https://github.com/microsoft/react-native-windows/pull/9898/files would no longer work if focusable is set to true anywhere. There could be other places where we'd need to change/add logic to account for this. |
| @@ -601,9 +602,15 @@ void ViewViewManager::TryUpdateView( | |||
| pViewShadowNode->GetControl().Content(visualRoot); | |||
|
|
|||
| if (useControl && pViewShadowNode->IsAccessible() != pViewShadowNode->IsFocusable()) { | |||
There was a problem hiding this comment.
| if (useControl && pViewShadowNode->IsAccessible() != pViewShadowNode->IsFocusable()) { | |
| if (useControl && (pViewShadowNode->IsAccessible() != pViewShadowNode->IsFocusable())) { |
There was a problem hiding this comment.
Maybe let's add a set of parentheses here for some clarity/to ensure proper order of operations.
There was a problem hiding this comment.
Not sure that's needed here because the second expression is a comparison and not a & and | operator
|
@chiaramooney this sounds like a breaking change, so please make sure to call it out and document it in the release notes |
asklar
added
the
Breaking Change
Description
Type of Change
Why
Following change to accessible/focusable prop relationship in #9840, request from partner to adjust logic in order to reduce number of code edits needed.
#9840 was needed in order to bring RNW up to Windows accessibility standards. In Windows accessibility focus and keyboard focus are the same. RNW should not allow developers to remove elements from the UIA while they still remain keyboard focusable.
What
Originally, the PR set the behavior to be if either accessible or focusable was set to false the control should not be focusable or accessible. The logic is now if either accessible or focusable is set to true the control should be focusable and accessible.
Microsoft Reviewers: Open in CodeFlow