Fix Bug in Accessible/Focusable Behavior #9840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Apr 17, 2022
vnext/Microsoft.ReactNative/Views/FrameworkElementViewManager.cpp
Outdated
Show resolved
Hide resolved
AgneLukoseviciute
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
According to UIA and Narrator team, on Windows, keyboard focus and accessibility focus should always point to the same element. Currently in RNW, when a focusable element is passed accessible=false, the element is removed from the UIA tree but remains keyboard focusable. Thus the user, when tabbing to an element with accessible=false with a screen reader enabled, can see keyboard focus move to the element and accessibility focus jump to the app window. Then, the screen reader announces window creating a poor/disorienting screen reader experience.
Resolves #9826
What
Modify native handling of accessible and focusable prop for view based and control based components such that both accessible and focusable must be true for an element to be focusable and accessible. If one is set to false, the component will behave as if both have been set to false.
Testing
Tested in playground and playground win32 by setting accessible and focusable to all configurations on a range of components and running narrator.
Microsoft Reviewers: Open in CodeFlow