-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Desktop DLL to ARM64EC #13320
Merged
Merged
Port Desktop DLL to ARM64EC #13320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Older SDK versions do not contain softintrin.h See http://www.emulators.com/docs/abc_arm64ec_explained.htm
rasaha91
approved these changes
Jun 8, 2024
vmoroz
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 11, 2024
* Add ARM64EC Platform * Add property sheets * Add packages.lock.json * Upgrade WinSDK version for C/C++ projects Older SDK versions do not contain softintrin.h See http://www.emulators.com/docs/abc_arm64ec_explained.htm * Do not build Integration Test projects for ARM64EC * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Exclude OpenSSL on Desktop DLL for ARM64EC * Override WinAppSDK _MrtCoreRuntimeIdentifier * Update packages.lock.json * Add explicit LIB dependencies for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Change files * Simplify condition for WindowsAppSDKOverrides * Switch from ARM64 to ARM64EC in Desktop CI * Update prepare-build-env.yml * Enable ARM64EC on PullRequest env * Remove OpenSSL from Desktop LIB and DLL * /t:Vars - Log SolutionName
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jun 11, 2024
* Add ARM64EC Platform * Add property sheets * Add packages.lock.json * Upgrade WinSDK version for C/C++ projects Older SDK versions do not contain softintrin.h See http://www.emulators.com/docs/abc_arm64ec_explained.htm * Do not build Integration Test projects for ARM64EC * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Exclude OpenSSL on Desktop DLL for ARM64EC * Override WinAppSDK _MrtCoreRuntimeIdentifier * Update packages.lock.json * Add explicit LIB dependencies for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Change files * Simplify condition for WindowsAppSDKOverrides * Switch from ARM64 to ARM64EC in Desktop CI * Update prepare-build-env.yml * Enable ARM64EC on PullRequest env * Remove OpenSSL from Desktop LIB and DLL * /t:Vars - Log SolutionName
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 19, 2024
* Add ARM64EC Platform * Add property sheets * Add packages.lock.json * Upgrade WinSDK version for C/C++ projects Older SDK versions do not contain softintrin.h See http://www.emulators.com/docs/abc_arm64ec_explained.htm * Do not build Integration Test projects for ARM64EC * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Exclude OpenSSL on Desktop DLL for ARM64EC * Override WinAppSDK _MrtCoreRuntimeIdentifier * Update packages.lock.json * Add explicit LIB dependencies for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Change files * Simplify condition for WindowsAppSDKOverrides * Switch from ARM64 to ARM64EC in Desktop CI * Update prepare-build-env.yml * Enable ARM64EC on PullRequest env * Remove OpenSSL from Desktop LIB and DLL * /t:Vars - Log SolutionName
JunielKatarn
added a commit
that referenced
this pull request
Jul 19, 2024
* Port Desktop DLL to ARM64EC (#13320) * Upgrade WinSDK version for C/C++ projects * Do not build Integration Test projects for ARM64EC * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Exclude OpenSSL on Desktop DLL for ARM64EC * Override WinAppSDK _MrtCoreRuntimeIdentifier * Add explicit LIB dependencies for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Remove OpenSSL from Desktop LIB and DLL * /t:Vars - Log SolutionName * Update Desktop NUSPEC to use ARM64EC (#13335) * Add ARM64EC strip slices
JunielKatarn
added a commit
that referenced
this pull request
Jul 20, 2024
* Upgrade Desktop solution/projects to Win SDK 10.0.22621.0 (#13326) * /t:Vars - Log SolutionName * Remove OpenSSL from Desktop LIB and DLL * Port Desktop DLL to ARM64EC (#13320) * Upgrade WinSDK version for C/C++ projects Older SDK versions do not contain softintrin.h See http://www.emulators.com/docs/abc_arm64ec_explained.htm * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Add ARM64EC to StripAdditionalPlatformsFromNuspec.ps1 --------- Co-authored-by: Jon Thysell <jthysell@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable building an ARM64EC flavor of
react-native-win32.dll
.Type of Change
Why
Major consumers of
react-native-win32.dll
require native performance as ARM64 devices become more broadly adopted.What
ARM64EC
platform to required projects.Testing
Changelog
react-native-win32.dll
onARM64EC
.Microsoft Reviewers: Open in CodeFlow