Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] Upgrade Desktop solution/projects to Win SDK 10.0.22621.0 #13326

Merged

Conversation

JunielKatarn
Copy link
Contributor

@JunielKatarn JunielKatarn commented Jun 10, 2024

Description

Upgrades Windows SDK for Desktop projects to version 10.0.22621.0.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

Building the Desktop DLL on ARM64EC requires a minimum Windows SDK version of 10.0.22000.0.

Note, version 10.0.22621.0 is now installed by default with the UWP workflow so using it instead of 10.0.22000.0 reduces the number of SDK dependencies installed in the developer machine.

Note, this change is not plainly backported from main to reduce impact on consumers of a stable branch.
At the same time, main consumers of react-native-win32.dll currently need to stick with 0.74-stable and they also need ARM64EC support.

What

  • Set WinSDK version to 10.0.22621.0 when The $(SolutionName) MSBuild variable is set to ReactWindows-Desktop.
  • Set WinSDK version to 10.0.22621.0 for Desktop.vcxproj and Desktop.DLL.vcxproj.
Microsoft Reviewers: Open in CodeFlow

@JunielKatarn JunielKatarn requested review from a team as code owners June 10, 2024 20:36
@JunielKatarn JunielKatarn enabled auto-merge (squash) June 10, 2024 21:08
@JunielKatarn JunielKatarn merged commit 9efa2f6 into microsoft:0.74-stable Jun 10, 2024
95 checks passed
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jun 11, 2024
…rosoft#13326)

* /t:Vars - Log SolutionName

* Upgrade Desktop solution/projects to Win SDK 10.0.22621.0

* Change files
JunielKatarn added a commit to jurocha-ms/react-native-windows that referenced this pull request Jul 19, 2024
…rosoft#13326)

* /t:Vars - Log SolutionName

* Upgrade Desktop solution/projects to Win SDK 10.0.22621.0

* Change files
JunielKatarn added a commit that referenced this pull request Jul 20, 2024
* Upgrade Desktop solution/projects to Win SDK 10.0.22621.0 (#13326)

* /t:Vars - Log SolutionName

* Remove OpenSSL from Desktop LIB and DLL

* Port Desktop DLL to ARM64EC (#13320)

* Upgrade WinSDK version for C/C++ projects
Older SDK versions do not contain softintrin.h
See http://www.emulators.com/docs/abc_arm64ec_explained.htm

* Make V8Platform x64 for ARM64EC

* Override HermesPlatform for ARM64EC

* Override WinAppSDK platforms for ARM64EC

* Skip React.Windows.IntegrationTests on ARM64EC

* Add ARM64EC to StripAdditionalPlatformsFromNuspec.ps1

---------

Co-authored-by: Jon Thysell <jthysell@microsoft.com>
@JunielKatarn JunielKatarn deleted the winsdk-10.0.22621.0-desktop-74 branch July 26, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants