Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentence breaker gets confused by property names. #1887

Closed
ghost opened this issue May 31, 2020 · 1 comment · Fixed by #1888
Closed

Sentence breaker gets confused by property names. #1887

ghost opened this issue May 31, 2020 · 1 comment · Fixed by #1888
Labels
bug resolved-fixed

Comments

@ghost
Copy link

ghost commented May 31, 2020

If the validation rule description resource string is "The property x.y is absent. It needs to be present.", then the sentence breaker thinks that "x." is the end of the sentence, and it sets the rule's short description to "The property x.".

Don't take "." as the end of the sentence unless it is followed by white space or it's the last character in the string.
@ghost ghost added the bug label May 31, 2020
@eddynaka eddynaka mentioned this issue May 31, 2020
Merged
@eddynaka eddynaka linked a pull request May 31, 2020 that will close this issue
updating method to create correct short description #1888
Merged
@ghost
Copy link
Author

ghost commented May 31, 2020

Fix was to use the existing extension method GetFirstSentence.

@ghost ghost closed this as completed in #1888 May 31, 2020
ghost pushed a commit that referenced this issue May 31, 2020
@eddynaka
Fix #1887: Sentence breaker gets confused by property names (#1888)
a651af9
@ghost ghost added the resolved-fixed label May 31, 2020
eddynaka added a commit that referenced this issue May 31, 2020
@eddynaka
Adding bugfix #1887 and feature #1880 to releasehistory file
ff0acaa
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug resolved-fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updating method to create correct short description microsoft/sarif-sdk
0 participants