Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating method to create correct short description #1888

Merged
1 commit merged into from
May 31, 2020
Merged

updating method to create correct short description #1888

1 commit merged into from
May 31, 2020

Conversation

eddynaka
Copy link
Collaborator

Refs #1887

Changes:

  • updating Skimmer to GetFirstSentence based on ExtensionMethods
  • adding a new test to GetFirstSentence to double check the result
  • updating output results to be correct based on the new GetFirstSentence method
  • removing unused method
  • updating some patterns and spacing in Skimmer file

@eddynaka eddynaka requested a review from a user May 31, 2020 19:42
@eddynaka eddynaka self-assigned this May 31, 2020
@eddynaka eddynaka linked an issue May 31, 2020 that may be closed by this pull request
Sentence breaker gets confused by property names. #1887
Closed
ghost
ghost approved these changes May 31, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit a651af9 into master May 31, 2020
@ghost ghost deleted the bugfix/wrong-short-description branch May 31, 2020 20:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@eddynaka eddynaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentence breaker gets confused by property names.
1 participant
@eddynaka