FEATURE : Provide overridable ShouldComputeHashes predicate method to prevent files from hashing.
#2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent files from hashing.
shaopeng-gh
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
shaopeng-gh
commented
Dec 30, 2022
| @@ -378,6 +378,11 @@ protected virtual bool ShouldEnqueue(string file, TContext context) | |||
| return shouldEnqueue; | |||
| } | |||
|
|
|||
| protected virtual bool ShouldComputeHashes(string file, TContext context) | |||
There was a problem hiding this comment.
This change enables override of ShouldComputeHashes instead of ShouldEnqueue
speed test of my local files folder with 7k files, roughly:
- previous PR using
ShouldEnqueue: 00:03:47 - similar to before any change, directly return true: 00:02:48
- this PR and override with the check we desire(if is binary): 00:02:13
after this merged next will send PR for BinSkim using it.
*also tested using filter .exe
no benifit at all, both around 00:02:32
michaelcfanning
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change only provides overridable for the derived class.