-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releasing 4.0.0 #2623
Releasing 4.0.0 #2623
Conversation
src/ReleaseHistory.md
Outdated
@@ -1,6 +1,6 @@ | |||
# SARIF Package Release History (SDK, Driver, Converters, and Multitool) | |||
|
|||
## **v3.2.0** (UNRELEASED) | |||
## **v4.0.0-rc1** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/4.0.0-rc1) | [Driver](https://www.nuget.org/packages/Sarif.Driver/4.0.0-rc1) | [Converters](https://www.nuget.org/packages/Sarif.Converters/4.0.0-rc1) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/4.0.0-rc1) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/4.0.0-rc1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's going on here exactly? Why do we have an RC?
We need to pick a version (not pre-release) and ship it.
It can be 3.2 or it can be 4.0 (due to the large number of breaking changes).
In general, let's not create multiple PRs for package release. Create one and then let the review process tell you what's right.
@EasyRhinoMSFT, what's the call? 3.2 or 4.0? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I see his reply with 4.0, I will update it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is anything with this that justifies a release candidate version. The SDK version is unrelated to BinSkim. As Michael noted this morning, what's in main is always release quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'm happy with 4.0, there's a lot of update to this one. :)
👍 In reply to: 1439215041 |
@michaelcfanning are you happy with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SARIF Package Release History (SDK, Driver, Converters, and Multitool)
v4.0.0 Sdk | Driver | Converters | Multitool | Multitool Library
SarifLogger
no longer allows providing aTool
instance. Use therun
parameter instead (and populate it with any customTool
object). #2614SarifLogger
updates version details differently. #2611ToolComponent
argument toIAnalysisLogger.Log(ReportingDescriptor, Result)
method. #2611--normalize-for-github
argument to--normalize-for-ghas
forconvert
command and mark--normalize-for-github
as obsolete. #2581IAnalysisContext.LogToolNotification
method to addReportingDescriptor
parameter. This is required in order to populatedAssociatedRule
data inNotification
instances. The new method has an option value of null for theassociatedRule
parameter to maximize build compatibility. #2604LogMissingreportingConfiguration
helper toLogMissingReportingConfiguration
. #2599MaxFileSizeInKilobytes
from int to long inIAnalysisContext
and other classes. #2599Guid
properties defined in SARIF spec, updated Json schema to useuuid
, and updated C# object model to useGuid?
instead ofstring
. #2555AnalyzeCommandBase
as obsolete. This type will be removed in the next significant update. #2599LogUnhandledEngineException
no longer has a return value (and updates theRuntimeErrors
context property directly as other helpers do). #2599MultithreadedAnalyzeCommandBase
by correcting task creation. []Threading fixes #2618](Threading fixes #2618)Collection was modified; enumeration operation may not execute
inMultithreadedAnalyzeCommandBase
, raised when analyzing with the--hashes
switch. #2459. There was a previous attempt to fix this in #2447.match-results-forward
command fails to generate VersionControlDetails data. #2487match-results-forward
commands for results with sub-rule ids. #2486merge
command to properly produce runs by tool and version when passed the--merge-runs
argument. #2488IOException
andDirectoryNotFoundException
exceptions thrown bymerge
command when splitting by rule (due to invalid file characters in rule ids). #2513virtual
keyword for public methods and properties, by regenerate and manually sync the changes. #2537NullReferenceException
when file hashing fails (due to file locked or other errors reading the file). #2596PluginDriver
property (AdditionalOptionsProvider
) that allows additional options to be exported (typically for command-line arguments). #2599LogFileSkippedDueToSize
that fires a warning notification if any file is skipped due to exceeding size threshold. #2599ShouldEnqueue
predicate method to filter files from driver processing. #2599ShouldComputeHashes
predicate method to prevent files from hashing. #2601MaxFileSizeInKilobytes
, which will allow SDK users to change the value. (Default value is 1024) #2578GH1007
, which requires flattened result message so GHAS code scanning can ingest the log. #2580SarifLogger
with aFileRegionsCache
instance.InsertOptionalDataVisitor
(previously initialized exclusively fromFileRegionsCache.Instance
).trace and emitted timing data. Provide
ScanExecution` trace with no utilization.LogToolNotification
as called fromSarifLogger
. #2604--normalize-for-ghas
argument to therewrite
command to ensure rewritten SARIF is compatible with GitHub Advanced Security (GHAS) ingestion requirements. #2581SarifLogger
now supports extensions rules data when logging (by providing aToolComponent
instance to the result logging method). #2661SarifLogger
provides aComputeHashData
callback to provide hash data for in-memory scan targets. #2614HashUtilities.ComputeHashes(Stream)
and `ComputeHashesForText(string) helpers. #2614