Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add code coverage reports to CI/CD flow #3980

Closed
eavanvalkenburg opened this issue Dec 5, 2023 · 3 comments · Fixed by #4193
Closed

Python: Add code coverage reports to CI/CD flow #3980

eavanvalkenburg opened this issue Dec 5, 2023 · 3 comments · Fixed by #4193
Assignees
@eavanvalkenburg @rewrlution
Labels
docs and tests Improvements or additions to documentation needs help These are issues that are good candidates for the community to work on python Pull requests for the Python Semantic Kernel

Comments

@eavanvalkenburg
Copy link
Member

No description provided.

@shawncal shawncal added the triage label Dec 5, 2023
@eavanvalkenburg eavanvalkenburg added the python Pull requests for the Python Semantic Kernel label Dec 11, 2023
@eavanvalkenburg eavanvalkenburg changed the title Add code coverage reports to CI/CD flow Python: Add code coverage reports to CI/CD flow Dec 11, 2023
@eavanvalkenburg eavanvalkenburg mentioned this issue Dec 13, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2023
@eavanvalkenburg
Python: added code coverage and vscode tasks def for python (#4193)
24a0999 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
To improve the code and PR quality I want to add code coverage to the
dev dependencies, and setup. I then also added tasks into the python
folder for both the pre-commit config and running unit tests with code
coverage. Fixes #3980

Initially I excluded code coverage for all connectors, that needs to be
refined and this can also be added to the GH actions once we have it
setup well.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@eavanvalkenburg
Copy link
Member Author

Still needs to be included in CI/CD flows, once we have the coverage up to a certain percentage.

@matthewbolanos matthewbolanos added docs and tests Improvements or additions to documentation and removed triage labels Jan 3, 2024
@matthewbolanos matthewbolanos moved this to Backlog in Semantic Kernel Jan 5, 2024
@matthewbolanos matthewbolanos added the needs help These are issues that are good candidates for the community to work on label Jan 24, 2024
@rewrlution
Copy link
Contributor

As discussed, I will take this work item.

This was referenced Feb 20, 2024
Closed
Closed
@eavanvalkenburg eavanvalkenburg self-assigned this Mar 4, 2024
@eavanvalkenburg
Copy link
Member Author

This works now!

@github-project-automation github-project-automation bot moved this from Backlog to Sprint: Done in Semantic Kernel Mar 4, 2024
Bryan-Roe pushed a commit to Bryan-Roe-ai/semantic-kernel that referenced this issue Oct 6, 2024
@eavanvalkenburg
Python: added code coverage and vscode tasks def for python (microsof…
c56dab7 
…t#4193)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
To improve the code and PR quality I want to add code coverage to the
dev dependencies, and setup. I then also added tasks into the python
folder for both the pre-commit config and running unit tests with code
coverage. Fixes microsoft#3980

Initially I excluded code coverage for all connectors, that needs to be
refined and this can also be added to the GH actions once we have it
setup well.

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eavanvalkenburg eavanvalkenburg

@rewrlution rewrlution

Labels
docs and tests Improvements or additions to documentation needs help These are issues that are good candidates for the community to work on python Pull requests for the Python Semantic Kernel
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
4 participants
@matthewbolanos @eavanvalkenburg @shawncal @rewrlution