Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Pysdk issue 3980 (via rewrlution) #5096

Closed
wants to merge 12 commits into from

Conversation

moonbox3
Copy link
Contributor

@moonbox3 moonbox3 commented Feb 20, 2024

Motivation and Context

Handling @rewrlution's PR due to permission issues. Fixes #3980. Original PR is: #5063.

This PR is to add a Python coverage comment GitHub action to the CICD workflow, so that comments related to coverage change will be posted to a PR automatically.

In this PR:

  1. I updated the DEV_SETUP.md to include some instructions on how to enable pre-commit
  2. I added the coverage package as the dev dependency
  3. I updated the .coveragerc file so that .coverage is generated in relative path
  4. I added the workflow for generating and posting coverage comments.

Description

Contribution Checklist

Huijing Huang added 4 commits February 20, 2024 09:58
@moonbox3 moonbox3 requested a review from a team as a code owner February 20, 2024 19:31
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel documentation labels Feb 20, 2024
@moonbox3
Copy link
Contributor Author

moonbox3 commented Mar 6, 2024

Closing as this has been implemented.

@moonbox3 moonbox3 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Add code coverage reports to CI/CD flow
2 participants