Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: fix import from filters subdirectories #9641

Closed
eavanvalkenburg opened this issue Nov 11, 2024 · 0 comments · Fixed by #9856
Closed

Python: fix import from filters subdirectories #9641

eavanvalkenburg opened this issue Nov 11, 2024 · 0 comments · Fixed by #9856
Assignees
@eavanvalkenburg
Labels
filters Anything related to filters python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@eavanvalkenburg
Copy link
Member

The filters directory is missing any imports from the subdirectories, the public API surface should be present in function.init.py
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels Nov 11, 2024
@moonbox3 moonbox3 added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) filters Anything related to filters and removed triage labels Nov 11, 2024
@eavanvalkenburg eavanvalkenburg self-assigned this Nov 28, 2024
@eavanvalkenburg eavanvalkenburg moved this to Sprint: Planned in Semantic Kernel Nov 28, 2024
@eavanvalkenburg eavanvalkenburg moved this from Sprint: Planned to Sprint: In Progress in Semantic Kernel Dec 2, 2024
@eavanvalkenburg eavanvalkenburg mentioned this issue Dec 2, 2024
Merged
4 tasks
@eavanvalkenburg eavanvalkenburg moved this from Sprint: In Progress to Sprint: In Review in Semantic Kernel Dec 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@eavanvalkenburg
Python: graduate filters, add exception during addition and some clea…
e0042af 
…nup (#9856)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR graduates the filters.

This includes some updates to the docstrings.
And adds a specific Exception for errors during adding or removing of
filters.

Closes #9838 
Fixes #9641 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
@eavanvalkenburg eavanvalkenburg moved this from Sprint: In Review to Sprint: Done in Semantic Kernel Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eavanvalkenburg eavanvalkenburg

Labels
filters Anything related to filters python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
3 participants
@eavanvalkenburg @moonbox3 @markwallace-microsoft