Python: graduate filters, add exception during addition and some cleanup #9856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
moonbox3
approved these changes
Dec 2, 2024
eavanvalkenburg
force-pushed
the
graduate_filters
branch
from
f026d71 to
bd04bcc
Compare
alliscode
approved these changes
Dec 3, 2024
TaoChenOSU
reviewed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR graduates the filters.
This includes some updates to the docstrings.
And adds a specific Exception for errors during adding or removing of filters.
Closes #9838
Fixes #9641
Description
Contribution Checklist