Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: New Azure AI Inference Connector #7963

Merged
merged 27 commits into from
Sep 10, 2024
Merged

.Net: New Azure AI Inference Connector #7963

merged 27 commits into from
Sep 10, 2024

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Aug 7, 2024 •
edited
Loading

Motivation and Context

This PR brings support for Azure AI Studio Model Catalogs also deployed thru GitHub Models, this Connector uses the Azure AI Inference SDK library client.

Closes #3992
Closes #7958

@RogerBarreto
.Net: Azure AI Inference Connector - Project + References (#7961)
8d47e21 
### Motivation and Context

- Resolves Partially #7958
- [x] Update current Maas Connector with latest version of
Azure.AI.Inference beta.1
@RogerBarreto
.Net: Azure AI Inference - ADR (#7959)
7513a09 
### Motivation and Context

.Net ADR Describing the strategy and patterns to follow on this new
Connector.

Resolve #7957

- #7957
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
eceab3d
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation labels Aug 7, 2024
@RogerBarreto RogerBarreto changed the title .Net: [Draft] main -> feature-connectors-aiinference .Net: [Draft] main -> feature-connectors-azureaiinference Aug 7, 2024
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
7632b42
@RogerBarreto
.Net: Azure AI Inference Connector - Chat Completion Phase 1 (#7976)
8bf3a03 
### Motivation and Context

- Resolve Partially #7958
- [x] Update current Mass Connector patterns following latest OpenAI V2.
   - [x] Implement ChatCompletion for MaaS Connector.
@RogerBarreto
.Net: Azure AI Inference - Chat Streaming Phase 2 (#8076)
d1cfda8 
### Motivation and Context

- Resolve Partially #7958
   - [x] Implement ChatCompletion for MaaS Connector.
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
2e153c3
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
b8b5006
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
9f1753a
@RogerBarreto
.Net: Azure AI Studio Connector - Add ChatCompletion UnitTests - Phas…
febd316 
…e 1 (#8177)

### Motivation and Context

First Phase of Adding Unit Tests.

- Resolve Partially #7958 
    - Add Unit Tests + Coverage > 85%.
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
0eedee0
@RogerBarreto
.Net: Azure MaaS Connector: UTs - Phase 3 (#8180)
208753d 
### Motivation and Context

First Phase of Adding Unit Tests.

- Resolve Partially #7958 
    - Add Unit Tests + Coverage > 85%.
@RogerBarreto
.Net: Azure MaaS Connector: UTs - Phase 2 (#8179)
d9a95e7 
### Motivation and Context

First Phase of Adding Unit Tests.

- Resolve Partially #7958 
    - Add Unit Tests + Coverage > 85%.
@RogerBarreto
Merge branch 'main' into feature-connectors-azureaiinference
89cc38a
@RogerBarreto
.Net: Azure MaaS Connector: UTs - Phase 4 (#8191)
fcd5a51 
### Motivation and Context

First Phase of Adding Unit Tests.

- Resolve Partially #7958 
    - Add Unit Tests + Coverage > 85%.
@RogerBarreto
.Net: Azure MaaS Connector: Integration Tests (#8192)
120445e 
### Motivation and Context

Adding Missing Integration Tests.

- Resolve Partially #7958 
    - Add Integration Tests.
@RogerBarreto
.Net: Azure MaaS Connector: Samples (#8195)
81664bd 
### Motivation and Context

First Phase of Adding Unit Tests.

- Resolve Partially #7958 
    - Demo and Samples
@RogerBarreto RogerBarreto changed the title .Net: [Draft] main -> feature-connectors-azureaiinference .Net: New Azure AI Inference Connector Sep 4, 2024
@RogerBarreto RogerBarreto marked this pull request as ready for review September 4, 2024 10:27
@RogerBarreto RogerBarreto requested a review from a team as a code owner September 4, 2024 10:27
markwallace-microsoft
markwallace-microsoft reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reviewing but posting my feedback. Will get back to this later today.

The integration tests are failing for this branch: https://github.com/microsoft/semantic-kernel/actions/runs/10700124790

dotnet/src/Connectors/Connectors.AzureAIInference/Connectors.AzureAIInference.csproj Show resolved Hide resolved
...Connectors/Connectors.AzureAIInference/Extensions/AzureAIInferenceKernelBuilderExtensions.cs Show resolved Hide resolved
...ectors/Connectors.AzureAIInference/Extensions/AzureAIInferenceServiceCollectionExtensions.cs Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Connectors.AzureAIInference.csproj Show resolved Hide resolved
dotnet/src/InternalUtilities/samples/InternalUtilities/TestConfiguration.cs Outdated Show resolved Hide resolved
dotnet/src/IntegrationTests/TestSettings/AzureAIInferenceConfiguration.cs Outdated Show resolved Hide resolved
markwallace-microsoft
markwallace-microsoft reviewed Sep 4, 2024
View reviewed changes
dotnet/samples/Concepts/ChatCompletion/AzureAIInference_ChatCompletion.cs Outdated Show resolved Hide resolved
dotnet/samples/Concepts/ChatCompletion/AzureAIInference_ChatCompletionStreaming.cs Show resolved Hide resolved
dotnet/samples/Concepts/ChatCompletion/AzureAIInference_ChatCompletionStreaming.cs Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference.UnitTests/Core/ChatClientCoreTests.cs Outdated Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference.UnitTests/Core/ChatClientCoreTests.cs Outdated Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Core/ChatClientCore.cs Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Core/ChatClientCore.cs Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Core/ChatClientCore.cs Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Core/ChatClientCore.cs Outdated Show resolved Hide resolved
dotnet/src/Connectors/Connectors.AzureAIInference/Core/ChatClientCore.cs Show resolved Hide resolved
@RogerBarreto RogerBarreto mentioned this pull request Sep 6, 2024
Merged
markwallace-microsoft
markwallace-microsoft approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@markwallace-microsoft markwallace-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once Dmytro's comments are addressed we should be good to merge this. Please verify that the integration tests pass for this branch.

@RogerBarreto RogerBarreto added this pull request to the merge queue Sep 10, 2024
Merged via the queue into main with commit c11ab29 Sep 10, 2024
23 checks passed
@RogerBarreto RogerBarreto deleted the feature-connectors-azureaiinference branch September 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes

@dmytrostruk dmytrostruk dmytrostruk approved these changes

@SergeyMenshykh SergeyMenshykh Awaiting requested review from SergeyMenshykh

Assignees

@RogerBarreto RogerBarreto

Labels
documentation kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.Net: Azure MaaS Connector Tasks .Net: Create a connector for Azure MaaS
4 participants
@RogerBarreto @dmytrostruk @SergeyMenshykh @markwallace-microsoft