Skip to content

Commit

Permalink
Don't auto-generate the hidden field when creating profile stubs (#10714
Browse files Browse the repository at this point in the history
)

## Summary of the Pull Request
We no longer automatically write the 'hidden' field for profile stubs we create

**Note**: This does not retroactively remove the automatically generated hidden fields in current settings files

## PR Checklist
* [x] Closes #10539 
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [ ] Schema updated.
* [x] I work here

## Validation Steps Performed
Deleted the ubuntu stub in my settings file, booted up terminal, new created stub did not have the hidden field. Created a fragment that overrides the hidden field and it worked.
  • Loading branch information
PankajBhojwani authored Jul 21, 2021
1 parent 8779249 commit d1f152a
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/cascadia/TerminalSettingsModel/Profile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,6 @@ Json::Value Profile::GenerateStub() const
stub[JsonKey(SourceKey)] = winrt::to_string(source);
}

stub[JsonKey(HiddenKey)] = Hidden();

return stub;
}

Expand Down

0 comments on commit d1f152a

Please sign in to comment.