Don't auto-generate the hidden field when creating profile stubs #10714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
zadjii-msft
approved these changes
Jul 21, 2021
ghost
requested review from
miniksa,
carlos-zamora,
DHowett,
leonMSFT and
lhecker
lhecker
approved these changes
Jul 21, 2021
DHowett
approved these changes
Jul 21, 2021
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Rosefield
pushed a commit
to Rosefield/terminal
that referenced
this pull request
Jul 22, 2021
…rosoft#10714) ## Summary of the Pull Request We no longer automatically write the 'hidden' field for profile stubs we create **Note**: This does not retroactively remove the automatically generated hidden fields in current settings files ## PR Checklist * [x] Closes microsoft#10539 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Deleted the ubuntu stub in my settings file, booted up terminal, new created stub did not have the hidden field. Created a fragment that overrides the hidden field and it worked.
DHowett
pushed a commit
that referenced
this pull request
Aug 25, 2021
) ## Summary of the Pull Request We no longer automatically write the 'hidden' field for profile stubs we create **Note**: This does not retroactively remove the automatically generated hidden fields in current settings files ## PR Checklist * [x] Closes #10539 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Deleted the ubuntu stub in my settings file, booted up terminal, new created stub did not have the hidden field. Created a fragment that overrides the hidden field and it worked.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
We no longer automatically write the 'hidden' field for profile stubs we create
Note: This does not retroactively remove the automatically generated hidden fields in current settings files
PR Checklist
Validation Steps Performed
Deleted the ubuntu stub in my settings file, booted up terminal, new created stub did not have the hidden field. Created a fragment that overrides the hidden field and it worked.