Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background image path not appearing in SUI #11541

Closed
cinnamon-msft opened this issue Oct 19, 2021 · 4 comments · Fixed by #11580
Closed

Background image path not appearing in SUI #11541

cinnamon-msft opened this issue Oct 19, 2021 · 4 comments · Fixed by #11580
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@cinnamon-msft
Copy link
Contributor

Windows Terminal version (or Windows build number)

1.12.2861.0

Other Software

No response

Steps to reproduce

Set a background image for a profile.

Expected Behavior

The path should be in the text field.

Actual Behavior

The path doesn't appear in the text field but the background image is still applied.

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 19, 2021
@cinnamon-msft cinnamon-msft added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Oct 20, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 20, 2021
@elsaco

This comment has been minimized.

Sign in to view
@zadjii-msft

This comment has been minimized.

Sign in to view
@zadjii-msft zadjii-msft mentioned this issue Oct 20, 2021
Open
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 20, 2021
@ianjoneill ianjoneill mentioned this issue Oct 22, 2021
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 22, 2021
@ghost ghost closed this as completed in #11580 Oct 25, 2021
ghost pushed a commit that referenced this issue Oct 25, 2021
@ianjoneill
Ensure the background image path is displayed in the settings UI (#11580
9662bc6 
)

## Summary of the Pull Request
Ensures that the background image path is displayed in the settings UI.

## References
One of the items on #11353

## PR Checklist
* [x] Closes #11541
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Set the background image path and saw that it was displayed in the settings UI.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 25, 2021
DHowett pushed a commit that referenced this issue Dec 13, 2021
@ianjoneill @DHowett
Ensure the background image path is displayed in the settings UI (#11580
26e3703 
)

## Summary of the Pull Request
Ensures that the background image path is displayed in the settings UI.

## References
One of the items on #11353

## PR Checklist
* [x] Closes #11541
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Set the background image path and saw that it was displayed in the settings UI.

(cherry picked from commit 9662bc6)
DHowett pushed a commit that referenced this issue Dec 13, 2021
@ianjoneill @DHowett
Ensure the background image path is displayed in the settings UI (#11580
3a61514 
)

## Summary of the Pull Request
Ensures that the background image path is displayed in the settings UI.

## References
One of the items on #11353

## PR Checklist
* [x] Closes #11541
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Set the background image path and saw that it was displayed in the settings UI.

(cherry picked from commit 9662bc6)
@ghost
Copy link

ghost commented Dec 14, 2021

🎉This issue was addressed in #11580, which has now been successfully released as Windows Terminal Preview v1.12.3472.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2021

🎉This issue was addressed in #11580, which has now been successfully released as Windows Terminal v1.11.3471.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Dec 15, 2021
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Ensure the background image path is displayed in the settings UI ianjoneill/terminal
3 participants
@elsaco @zadjii-msft @cinnamon-msft