Ensure the background image path is displayed in the settings UI #11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianjoneill
commented
Oct 22, 2021
| @@ -1,4 +1,4 @@ | |||
| #include "pch.h" | |||
| #include "pch.h" | |||
There was a problem hiding this comment.
VS seems to have decided to strip a BOM out of the file.
|
The CI really doesn't like me - the x86 build timed out! |
ghost
added
Area-Settings UI
zadjii-msft
approved these changes
Oct 24, 2021
lhecker
approved these changes
Oct 24, 2021
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2021
) ## Summary of the Pull Request Ensures that the background image path is displayed in the settings UI. ## References One of the items on #11353 ## PR Checklist * [x] Closes #11541 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Set the background image path and saw that it was displayed in the settings UI. (cherry picked from commit 9662bc6)
DHowett
pushed a commit
that referenced
this pull request
Dec 13, 2021
) ## Summary of the Pull Request Ensures that the background image path is displayed in the settings UI. ## References One of the items on #11353 ## PR Checklist * [x] Closes #11541 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA ## Validation Steps Performed Set the background image path and saw that it was displayed in the settings UI. (cherry picked from commit 9662bc6)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Ensures that the background image path is displayed in the settings UI.
References
One of the items on #11353
PR Checklist
Validation Steps Performed
Set the background image path and saw that it was displayed in the settings UI.