-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some settings are now ignored #5535
Comments
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
OK, I created a new file and migrated my desired settings into it. Putting my setting in defaults:
it's still ignoring the Rows,Cols,Position and wordDelimiters. It is accepting fontSize and snapToGrid. |
That's not what that post says to do
|
I did delete the file (deleted - not emptied) and let Terminal recreate it. The "defaults" section I quoted from my file specifically says to put settings there I want to apply to all profiles. |
So some things need to go in "defaults" while others need to go out in the space you mentioned. It seems arbitrary. |
Thanks @zadjii-msft . Apparently the "globals" JSON path was removed in a recent patch? Musta missed that release note. Anyways this solved my problem of default profile launching default settings not the profile GUID I provided. |
Okay so there are largely two types of settings:
The next tricky part is that some people want to use a bunch of common settings for all their profiles. It's a pain to have to edit all of them by hand, which is why If you want more reading, I'd take a look at UsingJsonSettings.md. For more technical reading, see the Default Profiles Spec or even the Cascading Settings spec |
I would expect then that historySize and wordDelimiters would belong in "defaults" as (strictly speaking) they're profile settings, not application settings, but they apparently function out at the global (application) scope. Things get fuzzy when you're talking application-scope settings and default-for-all-profiles scope - they're very nearly the same thing, except for the handful of genuine application settings which can't go in any profile settings (including "defaults"). What would help is a comment at the global scope that settings here apply to the application (such as size and position), and then the parser could pop up errors about misplaced settings (profile-level settings given at the application scope, while functional, is "wrong" - they should be in "defaults" instead). |
Okay so We pretty recently changed the settings template to include links to some documentation that's in progress that'll help clear all this up (soontm) |
This property was deprecated in 0.11. We probably should have also added a warning message to help the community figure out that this property is gone and won't work anymore. This PR adds that warning. * I'm not going to list the enormous number of duped threads _wait yes I am_ * #5581 * #5547 * #5555 * #5557 * #5573 * #5532 * #5527 * #5535 * #5510 * #5511 * #5512 * #5513 * #5516 * #5515 * #5521 * This literally isn't even all of them * [x] Also mainly related to #5458 * [x] I work here * [x] Tests added/passed
This property was deprecated in 0.11. We probably should have also added a warning message to help the community figure out that this property is gone and won't work anymore. This PR adds that warning. * I'm not going to list the enormous number of duped threads _wait yes I am_ * #5581 * #5547 * #5555 * #5557 * #5573 * #5532 * #5527 * #5535 * #5510 * #5511 * #5512 * #5513 * #5516 * #5515 * #5521 * This literally isn't even all of them * [x] Also mainly related to #5458 * [x] I work here * [x] Tests added/passed (cherry picked from commit d6cae40)
none of these are effective any more. Window opens with defaults for size and position, and double-click-to-select is stopping at / chars, despite it not being in the list.
The text was updated successfully, but these errors were encountered: