Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for running the terminal core as a content process #12938

Closed
wants to merge 62 commits into from
Closed

Add support for running the terminal core as a content process #12938

wants to merge 62 commits into from

Commits on Apr 11, 2022

  1. I think this merges the-whole-thing into this branch. The remote co… 

    …ntrol doesn't render right, but I think that's because the actual HEAD of all this work is in `connection-factory`
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    e168413 View commit details
    Browse the repository at this point in the history

  2. I believe this merges the buisness of connection-factory, though th… 

    …ere are many issues.
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    bb49d50 View commit details
    Browse the repository at this point in the history

  3. Some comments because everything is hard

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    7731f59 View commit details
    Browse the repository at this point in the history

  4. Add a signal that the content can use to tell the window it's ready

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    996c71a View commit details
    Browse the repository at this point in the history

  5. A close button, and more logging

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    2f23e1f View commit details
    Browse the repository at this point in the history

  6. some short-circuits for these inits, to make them more stable

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    c3a9445 View commit details
    Browse the repository at this point in the history

  7. You know, there's 0% chance that this is the right pattern for this, … 

    …but it _works_
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    7e792b2 View commit details
    Browse the repository at this point in the history

  8. Add a kill button for manually killing the content

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    5a07282 View commit details
    Browse the repository at this point in the history

  9. This works to kill the content and have the app live

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    3d15b09 View commit details
    Browse the repository at this point in the history

  10. a fix for a crash when closing

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    ea9d3cb View commit details
    Browse the repository at this point in the history

  11. The sample app has a hard time loading TermControl resources so we're… 

    … just going to disable this for now
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    4a8f0e9 View commit details
    Browse the repository at this point in the history

  12. this was the part where I realized I dun goofed

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    eeb01a1 View commit details
    Browse the repository at this point in the history

  13. Revert "this was the part where I realized I dun goofed" 

    This reverts commit 64533c8.
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    dafb627 View commit details
    Browse the repository at this point in the history

  14. This too didn't work. Creating the XAML thing not on the XAML thing i… 

    …sn't going to work
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    1a78557 View commit details
    Browse the repository at this point in the history

  15. Revert "This too didn't work. Creating the XAML thing not on the XAML… 

    … thing isn't going to work"

This reverts commit fd364db.
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    35ca313 View commit details
    Browse the repository at this point in the history

  16. This doesn't immediately crash, but it does crash when you start aski… 

    …ng for the actual text ranges. That's not what you want.
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    8ceb9ba View commit details
    Browse the repository at this point in the history

  17. some cleanup

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    768d4c0 View commit details
    Browse the repository at this point in the history

  18. add a dialog internally to the bounds of the control, not outside of … 

    …the control
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    651efe2 View commit details
    Browse the repository at this point in the history

  19. Move the content process handling to a separate file in TermControl p… 

    …roject
    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    738d191 View commit details
    Browse the repository at this point in the history

  20. move the content process main to another file as well

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    f818885 View commit details
    Browse the repository at this point in the history

  21. simplify the interface here a bit

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    07ba33b View commit details
    Browse the repository at this point in the history

  22. BODGY, don't raise an event on destruction, that would be too...

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    cf70797 View commit details
    Browse the repository at this point in the history

  23. more cleanup

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    34601f7 View commit details
    Browse the repository at this point in the history

  24. Definitely needed those

    @zadjii-msft
    zadjii-msft committed Apr 11, 2022
    Configuration menu
    Copy the full SHA
    46e299d View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. The sample works again

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    1 Configuration menu
    Copy the full SHA
    5429fca View commit details
    Browse the repository at this point in the history

  2. add a velocity flag for this

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    1 Configuration menu
    Copy the full SHA
    b253440 View commit details
    Browse the repository at this point in the history

  3. derp

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    b312919 View commit details
    Browse the repository at this point in the history

  4. add localization back

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    857fb39 View commit details
    Browse the repository at this point in the history

  5. tried to make these blindli fire_and_forgets. Didn't work

    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    9141f04 View commit details
    Browse the repository at this point in the history

  6. start thinking about moving the timers to being threadpooltimers in t… 

    …he core. I think every x-proc call in TermControl logs that message, so _crap_
    @zadjii-msft
    zadjii-msft committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    76d8fa7 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. this reconnects the new window to the existing content process

    @zadjii-msft
    zadjii-msft committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    7b3ca83 View commit details
    Browse the repository at this point in the history

  2. own the handle

    @zadjii-msft
    zadjii-msft committed Apr 13, 2022
    1 Configuration menu
    Copy the full SHA
    33b1ab9 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    2a9eefc View commit details
    Browse the repository at this point in the history

  2. This actually works for not loading the resources

    @zadjii-msft
    zadjii-msft committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    99308b4 View commit details
    Browse the repository at this point in the history

  3. For this commit, I went with what was in #11501. That seems to have b… 

    …een wrong. I get all sorts of errors. I should to the opposite.
    @zadjii-msft
    zadjii-msft committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    bf0f516 View commit details
    Browse the repository at this point in the history

  4. Revert "For this commit, I went with what was in #11501. That seems t… 

    …o have been wrong. I get all sorts of errors. I should to the opposite."

This reverts commit bf0f516.
    @zadjii-msft
    zadjii-msft committed Apr 15, 2022
    1 Configuration menu
    Copy the full SHA
    358edd5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Revert "start thinking about moving the timers to being threadpooltim… 

    …ers in the core. I think every x-proc call in TermControl logs that message, so _crap_"

This reverts commit 76d8fa7.
    @zadjii-msft
    zadjii-msft committed Apr 18, 2022
    1 Configuration menu
    Copy the full SHA
    b1ee82a View commit details
    Browse the repository at this point in the history

  2. Make the window smaller because the default is HUUEG

    @zadjii-msft
    zadjii-msft committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    ce8f8fb View commit details
    Browse the repository at this point in the history

  3. When trying to use Narrator, this gets hit and throws an exception. P… 

    …lumb it through instead
    @zadjii-msft
    zadjii-msft committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    07a1a07 View commit details
    Browse the repository at this point in the history

  4. For this commit, I went with what was in #11501. That seems to have b… 

    …een wrong. I get all sorts of errors. I should to the opposite.

(cherry picked from commit bf0f516)
    @zadjii-msft
    zadjii-msft committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    91977be View commit details
    Browse the repository at this point in the history

  5. this seems to work with narrator. I think this is what I was trying t… 

    …o do
    @zadjii-msft
    zadjii-msft committed Apr 18, 2022
    1 Configuration menu
    Copy the full SHA
    082c63b View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. cleanup from fixed a11y code

    @zadjii-msft
    zadjii-msft committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    c588a9c View commit details
    Browse the repository at this point in the history

  2. hey look this assert() doesn't hit anymore

    @zadjii-msft
    zadjii-msft committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a74b45a View commit details
    Browse the repository at this point in the history

  3. add logging

    @zadjii-msft
    zadjii-msft committed Apr 19, 2022
    1 Configuration menu
    Copy the full SHA
    446d07e View commit details
    Browse the repository at this point in the history

  4. Reduce the diff size trivially

    @zadjii-msft
    zadjii-msft committed Apr 19, 2022
    1 Configuration menu
    Copy the full SHA
    bbe32f8 View commit details
    Browse the repository at this point in the history

  5. woah typos

    @zadjii-msft
    zadjii-msft committed Apr 19, 2022
    1 Configuration menu
    Copy the full SHA
    a38fe5f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. yes I know this doesn't return that's the whole point

    @zadjii-msft
    zadjii-msft committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f898855 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    02fa24c View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    7d4ee45 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed May 5, 2022
    Configuration menu
    Copy the full SHA
    eac5ceb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed May 24, 2022
    Configuration menu
    Copy the full SHA
    223e270 View commit details
    Browse the repository at this point in the history

  2. some nits

    @zadjii-msft
    zadjii-msft committed May 24, 2022
    Configuration menu
    Copy the full SHA
    52f7664 View commit details
    Browse the repository at this point in the history

  3. more nits, more a11y stuff

    @zadjii-msft
    zadjii-msft committed May 24, 2022
    Configuration menu
    Copy the full SHA
    44ac527 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    7707716 View commit details
    Browse the repository at this point in the history

  2. this was LOAD BEARING

    @zadjii-msft
    zadjii-msft committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    f7d9384 View commit details
    Browse the repository at this point in the history

  3. this was definitely a bug

    @zadjii-msft
    zadjii-msft committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    023eb75 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. that was vestigial anyways

    @zadjii-msft
    zadjii-msft committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b8cd2b2 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    702e15c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi… 

    …nity-war
    @zadjii-msft
    zadjii-msft committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    3434208 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Merge branch 'main' into dev/migrie/oop/2/infinity-war

    @zadjii-msft
    zadjii-msft committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e09b674 View commit details
    Browse the repository at this point in the history

  2. nots from review

    @zadjii-msft
    zadjii-msft committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    852208a View commit details
    Browse the repository at this point in the history

  3. Migrate spelling-0.0.21 changes from main

    @DHowett
    DHowett committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e52e720 View commit details
    Browse the repository at this point in the history