Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running the terminal core as a content process #12938

Closed
wants to merge 62 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
e168413
I think this merges `the-whole-thing` into this branch. The remote co…
zadjii-msft Aug 10, 2021
bb49d50
I believe this merges the buisness of `connection-factory`, though th…
zadjii-msft Aug 10, 2021
7731f59
Some comments because everything is hard
zadjii-msft Aug 10, 2021
996c71a
Add a signal that the content can use to tell the window it's ready
zadjii-msft Aug 12, 2021
2f23e1f
A close button, and more logging
zadjii-msft Aug 12, 2021
c3a9445
some short-circuits for these inits, to make them more stable
zadjii-msft Aug 12, 2021
7e792b2
You know, there's 0% chance that this is the right pattern for this, …
zadjii-msft Aug 12, 2021
5a07282
Add a kill button for manually killing the content
zadjii-msft Aug 12, 2021
3d15b09
This works to kill the content and have the app live
zadjii-msft Aug 12, 2021
ea9d3cb
a fix for a crash when closing
zadjii-msft Aug 16, 2021
4a8f0e9
The sample app has a hard time loading TermControl resources so we're…
zadjii-msft Aug 16, 2021
eeb01a1
this was the part where I realized I dun goofed
zadjii-msft Aug 16, 2021
dafb627
Revert "this was the part where I realized I dun goofed"
zadjii-msft Aug 16, 2021
1a78557
This too didn't work. Creating the XAML thing not on the XAML thing i…
zadjii-msft Aug 16, 2021
35ca313
Revert "This too didn't work. Creating the XAML thing not on the XAML…
zadjii-msft Aug 16, 2021
8ceb9ba
This doesn't immediately crash, but it does crash when you start aski…
zadjii-msft Aug 16, 2021
768d4c0
some cleanup
zadjii-msft Aug 24, 2021
651efe2
add a dialog internally to the bounds of the control, not outside of …
zadjii-msft Aug 24, 2021
738d191
Move the content process handling to a separate file in TermControl p…
zadjii-msft Aug 24, 2021
f818885
move the content process main to another file as well
zadjii-msft Aug 24, 2021
07ba33b
simplify the interface here a bit
zadjii-msft Aug 24, 2021
cf70797
BODGY, don't raise an event on destruction, that would be too...
zadjii-msft Aug 24, 2021
34601f7
more cleanup
zadjii-msft Aug 25, 2021
46e299d
Definitely needed those
zadjii-msft Apr 11, 2022
5429fca
The sample works again
zadjii-msft Apr 12, 2022
b253440
add a velocity flag for this
zadjii-msft Apr 12, 2022
b312919
derp
zadjii-msft Apr 12, 2022
857fb39
add localization back
zadjii-msft Apr 12, 2022
9141f04
tried to make these blindli fire_and_forgets. Didn't work
zadjii-msft Apr 12, 2022
76d8fa7
start thinking about moving the timers to being threadpooltimers in t…
zadjii-msft Apr 12, 2022
7b3ca83
this reconnects the new window to the existing content process
zadjii-msft Apr 13, 2022
33b1ab9
own the handle
zadjii-msft Apr 13, 2022
2a9eefc
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Apr 15, 2022
99308b4
This actually works for not loading the resources
zadjii-msft Apr 15, 2022
bf0f516
For this commit, I went with what was in #11501. That seems to have b…
zadjii-msft Apr 15, 2022
358edd5
Revert "For this commit, I went with what was in #11501. That seems t…
zadjii-msft Apr 15, 2022
b1ee82a
Revert "start thinking about moving the timers to being threadpooltim…
zadjii-msft Apr 18, 2022
ce8f8fb
Make the window smaller because the default is HUUEG
zadjii-msft Apr 18, 2022
07a1a07
When trying to use Narrator, this gets hit and throws an exception. P…
zadjii-msft Apr 18, 2022
91977be
For this commit, I went with what was in #11501. That seems to have b…
zadjii-msft Apr 15, 2022
082c63b
this seems to work with narrator. I think this is what I was trying t…
zadjii-msft Apr 18, 2022
c588a9c
cleanup from fixed a11y code
zadjii-msft Apr 19, 2022
a74b45a
hey look this assert() doesn't hit anymore
zadjii-msft Apr 19, 2022
446d07e
add logging
zadjii-msft Apr 19, 2022
bbe32f8
Reduce the diff size trivially
zadjii-msft Apr 19, 2022
a38fe5f
woah typos
zadjii-msft Apr 19, 2022
f898855
yes I know this doesn't return that's the whole point
zadjii-msft Apr 20, 2022
02fa24c
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Apr 20, 2022
7d4ee45
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Apr 28, 2022
eac5ceb
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft May 5, 2022
223e270
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft May 24, 2022
52f7664
some nits
zadjii-msft May 24, 2022
44ac527
more nits, more a11y stuff
zadjii-msft May 24, 2022
7707716
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Jun 21, 2022
f7d9384
this was LOAD BEARING
zadjii-msft Jun 21, 2022
023eb75
this was definitely a bug
zadjii-msft Jun 21, 2022
b8cd2b2
that was vestigial anyways
zadjii-msft Jun 22, 2022
702e15c
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Jul 6, 2022
3434208
Merge remote-tracking branch 'origin/main' into dev/migrie/oop/2/infi…
zadjii-msft Jul 11, 2022
e09b674
Merge branch 'main' into dev/migrie/oop/2/infinity-war
zadjii-msft Sep 1, 2022
852208a
nots from review
zadjii-msft Sep 1, 2022
e52e720
Migrate spelling-0.0.21 changes from main
DHowett Sep 1, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/spelling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ File | Purpose | Format | Info
[reject.txt](reject.txt) | Remove words from the dictionary (after allow) | grep pattern matching whole dictionary words | [reject](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-reject)
[excludes.txt](excludes.txt) | Files to ignore entirely | perl regular expression | [excludes](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-excludes)
[patterns/*.txt](patterns/) | Patterns to ignore from checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[candidate.patterns](candidate.patterns) | Patterns that might be worth adding to [patterns.txt](patterns.txt) | perl regular expression with optional comment block introductions (all matches will be suggested) | [candidates](https://github.com/check-spelling/check-spelling/wiki/Feature:-Suggest-patterns)
[line_forbidden.patterns](line_forbidden.patterns) | Patterns to flag in checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[expect/*.txt](expect.txt) | Expected words that aren't in the dictionary | one word per line (sorted, alphabetically) | [expect](https://github.com/check-spelling/check-spelling/wiki/Configuration#expect)
[advice.md](advice.md) | Supplement for GitHub comment when unrecognized words are found | GitHub Markdown | [advice](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice)
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/spelling/advice.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ See the `README.md` in each directory for more information.
:microscope: You can test your commits **without** *appending* to a PR by creating a new branch with that extra change and pushing it to your fork. The [check-spelling](https://github.com/marketplace/actions/check-spelling) action will run in response to your **push** -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. :wink:


<details><summary>:clamp: If the flagged items are false positives</summary>
<details><summary>If the flagged items are :exploding_head: false positives</summary>

If items relate to a ...
* binary file (or some other file you wouldn't want to check at all).
Expand Down
12 changes: 10 additions & 2 deletions .github/actions/spelling/allow/allow.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
admins
allcolors
apc
Apc
apc
breadcrumb
breadcrumbs
bsd
Expand All @@ -14,8 +14,8 @@ CMMI
copyable
cybersecurity
dalet
dcs
Dcs
dcs
dialytika
dje
downside
Expand All @@ -34,10 +34,12 @@ gantt
gcc
geeksforgeeks
ghe
github
gje
godbolt
hostname
hostnames
https
hyperlink
hyperlinking
hyperlinks
Expand All @@ -54,9 +56,11 @@ Llast
llvm
Lmid
locl
lol
lorem
Lorigin
maxed
minimalistic
mkmk
mnt
mru
Expand All @@ -80,6 +84,7 @@ runtimes
shcha
slnt
Sos
ssh
timeline
timelines
timestamped
Expand All @@ -88,6 +93,7 @@ tokenizes
tonos
toolset
tshe
ubuntu
uiatextrange
UIs
und
Expand All @@ -96,5 +102,7 @@ versioned
vsdevcmd
We'd
wildcards
XBox
YBox
yeru
zhe
9 changes: 5 additions & 4 deletions .github/actions/spelling/allow/apis.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ DERR
dlldata
DNE
DONTADDTORECENT
DWMWA
DWORDLONG
DWMSBT
DWMWA
DWMWA
DWORDLONG
endfor
ENDSESSION
enumset
Expand Down Expand Up @@ -110,8 +110,8 @@ memchr
memicmp
MENUCOMMAND
MENUDATA
MENUITEMINFOW
MENUINFO
MENUITEMINFOW
mmeapi
MOUSELEAVE
mov
Expand Down Expand Up @@ -158,8 +158,8 @@ rcx
REGCLS
RETURNCMD
rfind
roundf
ROOTOWNER
roundf
RSHIFT
SACL
schandle
Expand Down Expand Up @@ -211,6 +211,7 @@ UPDATEINIFILE
userenv
USEROBJECTFLAGS
Viewbox
virtualalloc
wcsstr
wcstoui
winmain
Expand Down
Loading