Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load CommandPalette and AboutDialog #15196

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Lazy load CommandPalette and AboutDialog #15196

merged 1 commit into from
Apr 18, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Apr 17, 2023 •
edited
Loading

This sets x:Load to false for the two elements.
On my system, with Windows Defender disabled, this reduces CPU
usage by 15ms and the visual delay during launch by 40ms.

Part of #5907

PR Checklist

  • Ctrl+Shift+P opens command palette ✅
  • Context menu opens command palette ✅
  • Context menu opens about dialog ✅

@lhecker lhecker added Area-Performance Performance-related issue Product-Terminal The new Windows Terminal. labels Apr 17, 2023
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 2ae3c9c into dev/lhecker/fix-peasant-active-window Apr 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the dev/lhecker/lazy-command-palette branch April 18, 2023 16:23
@lhecker lhecker restored the dev/lhecker/lazy-command-palette branch April 18, 2023 16:40
@lhecker
Copy link
Member Author

lhecker commented Apr 18, 2023

This PR was accidentally merged into my other (stacked) PR. I've reopened this one here: #15203 (same commit hash).

This was referenced Apr 21, 2023
Closed
Merged
DHowett pushed a commit that referenced this pull request Apr 21, 2023
@zadjii-msft
Make sure the command palette isn't null (#15220)
4788347 
Fixes a crash when pressing a keybinding in the settings tab. 

Regressed in #15196.

Noted in #14051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Performance Performance-related issue AutoMerge Marked for automatic merge by the bot when requirements are met Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhecker @zadjii-msft