AtlasEngine: Fix invalidation when the cursor is invisible #15904
Conversation
microsoft-github-policy-service
bot
added
Issue-Bug
| @@ -251,6 +251,16 @@ try | |||
| { | |||
| _flushBufferLine(); | |||
|
|
|||
| // PaintCursor() is only called when the cursor is visible, but we need to invalidate the cursor area | |||
| // even if it isn't. Otherwise a transition from a visible to an invisible cursor wouldn't be rendered. | |||
There was a problem hiding this comment.
The confusing part here (at least for me) and what led to this bug, is that there's a distinction in our code between a visible cursor and a cursor that's "on". !IsCursorVisible() forces the cursor to not be drawn, but it can still be on/off when it blinks while being invisible.
...and while it blinks it still gets invalidated (why tho?).
BTW there's also IsConversionArea() which is supposed to be an invisibility flag, but it must've gotten broken at some point in conhost's rewrite to C++ so now it is visible (whoops) but unlike !IsCursorVisible() it doesn't invalidate the area being drawn, so it just happens to work (unless you invalidate the cursor).
As mentioned yesterday, the cursor code is not in a great shape right now. 🥲
lhecker
changed the title
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/atlasengine-fixup
branch
`PaintCursor()` is only called when the cursor is visible, but we need to invalidate the cursor area even if it isn't. Otherwise a transition from a visible to an invisible cursor wouldn't be rendered. I'm confident that this closes #15199 ## Validation Steps Performed * Set blink duration extremely high * Launch pwsh.exe * Press Enter a few times * Press Ctrl+L * There are never 2 cursors visible, not even briefly ✅ (cherry picked from commit 60843fa) Service-Card-Id: 90438488 Service-Version: 1.18
PaintCursor()is only called when the cursor is visible, but we needto invalidate the cursor area even if it isn't. Otherwise a transition
from a visible to an invisible cursor wouldn't be rendered.
I'm confident that this closes #15199
Validation Steps Performed