-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtkeychain] Fix the CMake export target on windows #25018
Conversation
I tested the usage successfull :
|
The upstream PR has just been merged. |
This PR is still needed to pull the upstream changes in. But we can point to the particular comit instead of using a patch with the same content. I will prepare this tonight. |
Done. @JonLiu1993 can you have another look? I have also updated the qt6 version. |
LGTM, thanks for your pr! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks for the fix!
It turns out that the fix from #24013 that allows to use CMake < 3.18 does not work on windows. This adds a patch that reintroduces the alias solution but under a cmake version guard.
I have propose this also upstream frankosterfeld/qtkeychain#212, but did not yet get a responds since May 8th.
What does your PR fix?
It fixes the exported CMake target on windows
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes