[qtbase] ios support #29220
Closed
[qtbase] ios support #29220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
reviewed
Jan 28, 2023
| @@ -0,0 +1,22 @@ | |||
| diff --git a/src/gui/rhi/qrhigles2.cpp b/src/gui/rhi/qrhigles2.cpp | |||
There was a problem hiding this comment.
We'd better to push this changes to the upstream first / later.
There was a problem hiding this comment.
I agree, this is tricky enough I would like to see that it has been at least submitted upstream before merging this.
/cc @Neumann-A
There was a problem hiding this comment.
Fair point. I was speculating for someone here already with content knowledge.
JackBoosY
approved these changes
Jan 28, 2023
MonicaLiu0311
added
category:port-feature
MonicaLiu0311
approved these changes
Feb 3, 2023
MonicaLiu0311
added
the
info:reviewed
BillyONeal
added
depends:upstream-changes
|
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". |
|
Superseded by #36407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ios support for qtbase
I am only halfway convinced by this, as upstream seems to be able to produce binaries without the patch. But the "controlled" platform headers (
OpenGLES.framework/Headers/ES2/glext.h) only containsGL_MIN_EXTand noGL_MIN.I wonder if upstream builds without
gles2(which is deprecated for ios) or if it's something else.But since this builds for me, I'll put it up for discussion here anyway.
./vcpkg x-add-version --alland committing the result.